Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Designer move menu icon not changing directions #15863

Closed
rabeehrz opened this issue Jan 27, 2020 · 3 comments
Closed

Designer move menu icon not changing directions #15863

rabeehrz opened this issue Jan 27, 2020 · 3 comments
Assignees
@williamdes
Labels
Bug A problem or regression with an existing feature has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete
Projects
Designer issues
Milestone
5.0.2

Comments

@rabeehrz
Copy link
Contributor

rabeehrz commented Jan 27, 2020 •
edited

Describe the bug

The move menu icon in the designer toolbar doesn't toggle when clicked.

To Reproduce

Steps to reproduce the behavior:

  1. Go to Designer
  2. Click on Move Menu icon at the bottom of the toolbar
  3. See the bug

Expected behavior

The icon should toggle between left and right.

Server configuration

  • Operating system: phpMyAdmin demo - MySQL (192.168.30.23 via TCP/IP
  • Web server: nginx/1.10.3
  • Database version: 8.0.18 - MySQL Community Server - GP
  • PHP version: 7.4.0
  • phpMyAdmin version: 5.0.1

Client configuration

  • Browser: Google Chrome
  • Operating system: macOS Catalina 10.15.2

Screenshots

movemenu.gif
@rabeehrz
Copy link
Contributor Author

@williamdes I would like to work on this issue. :)

@williamdes
Copy link
Member

@rabeehrz You can work on this issue, can you post a gif/video of the bug ?

@williamdes williamdes added the Bug A problem or regression with an existing feature label Jan 27, 2020
@williamdes williamdes added this to Needs triage in issues via automation Jan 27, 2020
@williamdes williamdes moved this from Needs triage to to be fixed soon in issues Jan 27, 2020
@williamdes williamdes added this to To Do in Designer Jan 27, 2020
@rabeehrz
Copy link
Contributor Author

@williamdes I've updated the issue with a gif of the bug. Will open a PR soon.

@rabeehrz rabeehrz mentioned this issue Jan 27, 2020
Merged
6 tasks
@williamdes williamdes added the has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete label Jan 27, 2020
@williamdes williamdes added this to the 5.0.2 milestone Jan 27, 2020
@williamdes williamdes self-assigned this Jan 28, 2020
@williamdes williamdes moved this from To Do to Done in Designer Jan 28, 2020
@williamdes williamdes changed the title Designer Move Menu icon doesn't toggle Designer move menu icon not changing directions Jan 28, 2020
williamdes added a commit that referenced this issue Jan 28, 2020
@williamdes
Add ChangeLog entry for #15863
c0db5f4 
Signed-off-by: William Desportes <williamdes@wdes.fr>
issues automation moved this from to be fixed soon to Closed Jan 28, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@williamdes williamdes

Labels
Bug A problem or regression with an existing feature has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete
Projects
Designer
Done
issues
  
Closed
Milestone
5.0.2
Development

No branches or pull requests
2 participants
@williamdes @rabeehrz