Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't search by IN condition because of dropdown #15876

Closed
yutv opened this issue Jan 29, 2020 · 5 comments
Closed

Can't search by IN condition because of dropdown #15876

yutv opened this issue Jan 29, 2020 · 5 comments
Assignees
Labels
Bug A problem or regression with an existing feature
Projects
Milestone

Comments

@yutv
Copy link

yutv commented Jan 29, 2020

Describe the bug

Can't search by the IN condition because of dropdown

To Reproduce

Steps to reproduce the behavior:

  1. Choose a table and go to the Search tab
  2. Select Operator = IN (...) for a field
    Result: impossible to select multiple values

Expected behavior

Expected to have ability to select multiple values in the Value column

Screenshot

image

Server configuration

  • Docker Image: phpmyadmin/phpmyadmin:latest
  • Database version: Percona Server 5.6.45-86.1-log Percona Server (GPL), Release 86.1, Revision 5bc37b1
  • phpMyAdmin version: 5.0.1

Client configuration

  • Browser: Google Chrome Version 79.0.3945.130 (Official Build) (64-bit)
  • Operating system: Ubuntu 18.04 on the host machine
@williamdes williamdes added this to Needs triage in issues via automation Jan 29, 2020
@williamdes williamdes added the Bug A problem or regression with an existing feature label Jan 29, 2020
@williamdes williamdes added this to the 5.0.2 milestone Jan 29, 2020
@williamdes williamdes moved this from Needs triage to Medium priority in issues Jan 29, 2020
@williamdes
Copy link
Member

Thank you for the report @yutv
I hope somebody will look into it ASAP

@lem9
Copy link
Contributor

lem9 commented Jan 30, 2020

Tested version 5.0.1 with sakila.film_category. I chose the IN(...) operator for the category_id column, used the standard CTRL/click to pick multiple values, and the correct query was generated.

@yutv
Copy link
Author

yutv commented Jan 30, 2020

@lem9 CTRL/click works only when dropdown is marked as multiple (http://i.imgur.com/H9mfshZ.png), but it is not multiple sometimes (http://i.imgur.com/5v1jrkO.png)

image

image

@williamdes
Copy link
Member

Reproduced successfully on QA_5_0 using a int(10) field and a int(11) field
int(10) is wrongly not multiple select

@williamdes williamdes self-assigned this Feb 22, 2020
williamdes added a commit that referenced this issue Feb 22, 2020
Signed-off-by: William Desportes <williamdes@wdes.fr>
@williamdes
Copy link
Member

In fact you will see on 001cc92 that the code uses indexes
So the second select field was wrong and could work depending on the structure of the table.
Using incremented indexes is sometimes risky..

issues automation moved this from Medium priority to Closed Feb 22, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug A problem or regression with an existing feature
Projects
issues
  
Closed
Development

No branches or pull requests

3 participants