Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show / Hide query box text link #15880

Closed
yashrajbothra opened this issue Jan 29, 2020 · 7 comments · Fixed by #15884
Closed

Show / Hide query box text link #15880

yashrajbothra opened this issue Jan 29, 2020 · 7 comments · Fixed by #15884
Assignees
@williamdes
Labels
enhancement A feature request for improving phpMyAdmin ui Issues relating to the user interface
Projects
Enhancements
Milestone
5.1.0

Comments

@yashrajbothra
Copy link
Contributor

Is your feature request related to a problem? Please describe.

image

Describe the solution you'd like

Could be a button or Link rather than pain text
@rabeehrz
Copy link
Contributor

@williamdes I would like to work on this.

@williamdes
Copy link
Member

I am not sure to understand

And "rather than pain text" confused me on the interpretation

@yashrajbothra
Copy link
Contributor Author

yashrajbothra commented Jan 30, 2020 •
edited

@williamdes I mean it could be a button like this
image

or a link like:
image

Just pain text doesn't appeal to much as a clickable.

@williamdes
Copy link
Member

Okay, I understand
Why not :)

@rabeehrz
Copy link
Contributor

@williamdes I'll work on this?

@williamdes
Copy link
Member

Yes you can
Maybe another team member could comment if we should change the text to a button?

@MauricioFauth?

@MauricioFauth
Copy link
Member

I think a button is a good idea.

@rabeehrz rabeehrz mentioned this issue Jan 30, 2020
Merged
@williamdes williamdes added enhancement A feature request for improving phpMyAdmin ui Issues relating to the user interface labels Feb 13, 2020
@williamdes williamdes added this to the 5.1.0 milestone Feb 13, 2020
@williamdes williamdes added this to Triage zone in Enhancements via automation Feb 13, 2020
@williamdes williamdes moved this from Triage zone to Interface in Enhancements Feb 13, 2020
@williamdes williamdes self-assigned this Feb 13, 2020
Enhancements automation moved this from Interface to Done Feb 13, 2020
williamdes added a commit that referenced this issue Feb 13, 2020
@williamdes
Add ChangeLog entry for #15880
d0c39d0 
Signed-off-by: William Desportes <williamdes@wdes.fr>
williamdes added a commit that referenced this issue Feb 13, 2020
@williamdes
Fix tests for PR #15884 - Fix #15880 Change "Show Query" link to a bu…
14b1fdf 
…tton

Signed-off-by: William Desportes <williamdes@wdes.fr>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@williamdes williamdes

Labels
enhancement A feature request for improving phpMyAdmin ui Issues relating to the user interface
Projects
Enhancements
  
Done
Milestone
5.1.0
Development

Successfully merging a pull request may close this issue.

Fix #15880: Change Show Query Link to button rabeehrz/phpmyadmin
4 participants
@MauricioFauth @williamdes @rabeehrz @yashrajbothra