Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modal draggability/expand (down) with screen zoom change. #15937

Closed
DavidThomas48 opened this issue Feb 9, 2020 · 8 comments
Closed

Modal draggability/expand (down) with screen zoom change. #15937

DavidThomas48 opened this issue Feb 9, 2020 · 8 comments
Assignees
@williamdes
Labels
Bug A problem or regression with an existing feature good first issue has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete ui Issues relating to the user interface
Projects
issues
Milestone
5.0.2

Comments

@DavidThomas48
Copy link

DavidThomas48 commented Feb 9, 2020 •
edited by williamdes

Describe the bug

Modal won't drag down to utilise space created by zooming out in the browser/

To Reproduce

Steps to reproduce the behavior:

  1. Open the "Edit Routine" modal
  2. Zoom out the browser view to give more space to extend the modal.
  3. Try to drag the modal's bottom edge down into the newly available space, but the bottom edge won't drag.

Expected behavior

The modal should be draggable into the new viewport space after zooming out.

Screenshots

image

image

image

Server configuration

Operating system:

  • Web server: Windows 10 64bit
    see above

Client configuration

Chrome 79.0.3945.130 on Windows 1- 64bit

Additional context

Add any other context about the problem here.
@williamdes williamdes added good first issue ui Issues relating to the user interface labels Feb 9, 2020
@williamdes williamdes added this to Needs triage in issues via automation Feb 9, 2020
@williamdes williamdes moved this from Needs triage to Reproduced in issues Feb 9, 2020
@bismitaguha
Copy link
Contributor

@williamdes Can I work on this issue?

@williamdes
Copy link
Member

Yes @bismitaguha you can

@vibhuti019
Copy link

Hello I am a newbie and would like to help out.

@williamdes
Copy link
Member

@bismitaguha are you working of this issue ?

@tabraiz961
Copy link
Contributor

Hi @williamdes can i work on this ?

@williamdes
Copy link
Member

Yes @tabraiz961
@vibhuti019 do you want to pick another issue ?

tabraiz961 added a commit to tabraiz961/phpmyadmin that referenced this issue Feb 13, 2020
@tabraiz961
Modal downward drag issue fix on zoom out phpmyadmin#15937
cfaa76d 
Signed-off-by: Tabraiz Malik <tabraizmalik96@gmail.com>
tabraiz961 added a commit to tabraiz961/phpmyadmin that referenced this issue Feb 13, 2020
@tabraiz961
Modal downward drag with screen zoom out closes phpmyadmin#15937
52a373e 
Signed-off-by: Tabraiz Malik <tabraizmalik96@gmail.com>
@vibhuti019
Copy link

Sure @williamdes . Please let me know.

tabraiz961 added a commit to tabraiz961/phpmyadmin that referenced this issue Feb 20, 2020
@tabraiz961
Modal drag on routines fixes phpmyadmin#15937
d545482
@tabraiz961 tabraiz961 mentioned this issue Feb 20, 2020
Merged
6 tasks
@williamdes williamdes added the has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete label Feb 20, 2020
@williamdes
Copy link
Member

@vibhuti019 did I give you one ?

@williamdes williamdes added the Bug A problem or regression with an existing feature label Feb 22, 2020
@williamdes williamdes changed the title Modal draggability with screen zoom change. Modal draggability/expand (down) with screen zoom change. Feb 22, 2020
@williamdes williamdes self-assigned this Feb 22, 2020
@williamdes williamdes added this to the 5.0.2 milestone Feb 22, 2020
williamdes added a commit that referenced this issue Feb 22, 2020
@williamdes
Merge #15979 - Fix #15937 - Modal draggability/expand (down) with scr…
629e470 
…een zoom change.

Pull-request: #15979
Fixes: #15937

Signed-off-by: William Desportes <williamdes@wdes.fr>
williamdes added a commit that referenced this issue Feb 22, 2020
@williamdes
Add ChangeLog entry for #15937
a6f71d5 
[ci skip]
Signed-off-by: William Desportes <williamdes@wdes.fr>
issues automation moved this from Reproduced to Closed Feb 22, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@williamdes williamdes

Labels
Bug A problem or regression with an existing feature good first issue has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete ui Issues relating to the user interface
Projects
issues
  
Closed
Milestone
5.0.2
Development

No branches or pull requests
5 participants
@DavidThomas48 @tabraiz961 @williamdes @bismitaguha @vibhuti019