Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export Maximal length of created query input too small #15954

Closed
DavidThomas48 opened this issue Feb 13, 2020 · 3 comments · Fixed by #15956
Closed

Export Maximal length of created query input too small #15954

DavidThomas48 opened this issue Feb 13, 2020 · 3 comments · Fixed by #15956
Assignees
@williamdes
Labels
Bug A problem or regression with an existing feature has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete ui Issues relating to the user interface
Projects
issues
Milestone
5.1.0

Comments

@DavidThomas48
Copy link

DavidThomas48 commented Feb 13, 2020 •
edited

Describe the bug

In the export page, the "Export Maximal length of created query" input is both too small to see the default value in there, and also seems to have scroll buttons to move it one byte at a time. When the default is 50000, one byte at a time is obviously not what it ought to be.

It used to be a plain text input with plenty of width - I think it should go back to being that.

image

  • Operating system: Win10

image

Client configuration

  • Browser: Chrome
  • Operating system: Win10
@williamdes williamdes added this to Needs triage in issues via automation Feb 13, 2020
@williamdes williamdes added Bug A problem or regression with an existing feature ui Issues relating to the user interface labels Feb 13, 2020
@stu01509
Copy link
Contributor

I'd like to work on this.

@williamdes
Copy link
Member

williamdes commented Feb 14, 2020 •
edited

@stu01509 go ahead :)

@stu01509 stu01509 mentioned this issue Feb 14, 2020
Merged
6 tasks
@stu01509
Copy link
Contributor

@williamdes Fixed, Please review this PR.

@williamdes williamdes linked a pull request Feb 14, 2020 that will close this issue
Fix #15954: Input number field size #15956
Merged
6 tasks
@williamdes williamdes added the has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete label Feb 14, 2020
@williamdes williamdes added this to the 5.1.0 milestone Mar 11, 2020
@williamdes williamdes self-assigned this Mar 11, 2020
williamdes added a commit to williamdes/phpmyadmintest that referenced this issue Mar 11, 2020
@williamdes
Merge phpmyadmin#15956 - Fix phpmyadmin#15954 - Export Maximal length…
b4d9e51 
… of created query input too small

Pull-request: phpmyadmin#15956
Fixes: phpmyadmin#15954

Signed-off-by: William Desportes <williamdes@wdes.fr>
williamdes added a commit to williamdes/phpmyadmintest that referenced this issue Mar 11, 2020
@williamdes
Add ChangeLog entry for phpmyadmin#15954
fcd52fa 
Signed-off-by: William Desportes <williamdes@wdes.fr>
issues automation moved this from Needs triage to Closed Mar 11, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@williamdes williamdes

Labels
Bug A problem or regression with an existing feature has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete ui Issues relating to the user interface
Projects
issues
  
Closed
Milestone
5.1.0
Development

Successfully merging a pull request may close this issue.

Fix #15954: Input number field size
3 participants
@DavidThomas48 @williamdes @stu01509