Unexpected "apply" tag

[garak]

Describe the bug

Uncaught Twig_Error_Syntax: Unexpected "apply" tag (expecting closing tag for the "set" tag defined near line 27). in /usr/share/phpmyadmin/templates/display/import/javascript.twig

To Reproduce

Steps to reproduce the behavior:

1. Go to import
2. See a 500 error popup
3. Find above error in log

Expected behavior

No error

Server configuration

• Operating system: Ubuntu 18.04
• Web server: nginx
• Database version: mysql 5.7.29-0ubuntu0.18.04.1
• PHP version: 7.4.3
• phpMyAdmin version: 4.9.4deb4

Client configuration

• Browser: Firefox 73.0
• Operating system: Ubuntu 18.04

[williamdes]

Ref: https://salsa.debian.org/phpmyadmin-team/phpmyadmin/issues/43

[williamdes]

I need to investigate if it is a solution to upgrade twig on the PPA

@garak are you using the PPA ?

[garak]

I do

[williamdes]

So my recent upload did break things..
I will try to fix this ASAP

b475cfd
bd33d92
99250a8
eb8472b

Ubuntu bionic is at twig 2.4.6-1
Ubuntu eoan is at twig 2.11.3-2

[williamdes]

works for Twig 1.40+ and 2.9+: https://twigfiddle.com/jhf5f0

[williamdes]

One thought I had is WTF why did you remove the tag between 1.40 and 2.9 🤔
@fabpot do you have an idea ?

[MauricioFauth]

One thought I had is WTF why did you remove the tag between 1.40 and 2.9 🤔

It was not removed, it was added in 2.9 and backported to 1.40. Both versions were released at the same time, because Twig develops 1.x, 2.x and 3.x in parallel.

[williamdes]

One thought I had is WTF why did you remove the tag between 1.40 and 2.9 thinking

It was not removed, it was added in 2.9 and backported to 1.40. Both versions were released at the same time, because Twig develops 1.x, 2.x and 3.x in parallel.

Oh !
Maybe the documentation should be more clear about that
Eg: display the versions it is available on each tag
One line with versions restrictions in the composer format could be easyly readable

[garak]

It seems to be fixed with latest release of php-twig package
Thanks!