Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Extra" column definition not editable #15994

Closed
Simbiat opened this issue Feb 25, 2020 · 6 comments · Fixed by #16653
Closed

"Extra" column definition not editable #15994

Simbiat opened this issue Feb 25, 2020 · 6 comments · Fixed by #16653
Assignees
Labels
Bug A problem or regression with an existing feature has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete
Projects
Milestone

Comments

@Simbiat
Copy link
Contributor

Simbiat commented Feb 25, 2020

Describe the bug

When editing a column "extra" definitions are not editable and not visible. Only AUTO_INCREMENT is visible and editable as a separate option, but, for example, ON UPDATE CURRENT_TIMESTAMP is not visible or editable. Furthermore, when you try to edit such a column, such extra definition will be lost. It is retained however when exporting the table with such column.

To Reproduce

Steps to reproduce the behavior:

  1. Add column with ON UPDATE CURRENT_TIMESTAMP (will require manually running an SQL) clause in its definition
  2. Attempt to edit it through UI (say, add a comment)
  3. Save changes
  4. Check current definition of the column and see, that it's missing ON UPDATE CURRENT_TIMESTAMP

Expected behavior

At least it should show extra definitions and preserve them when changing column through UI. Ideally - also allow to edit them.

Screenshots

N/A

Server configuration

  • Operating system: Win10
  • Web server: Apache 2.4
  • Database version: 10.2.31-MariaDB
  • PHP version: 7.4.3
  • phpMyAdmin version: 5.0.1

Client configuration

  • Browser: MS Edge
  • Operating system: Win10

Additional context

N/A

@williamdes
Copy link
Member

Hi @Simbiat

Thank you for the report, I would say the bug is that it is not selected in the Extra selector automatically when editing the column ?

image

@williamdes williamdes added the Bug A problem or regression with an existing feature label Feb 28, 2020
@williamdes williamdes added this to Needs triage in issues via automation Feb 28, 2020
@williamdes williamdes moved this from Needs triage to to be fixed soon in issues Feb 28, 2020
@Simbiat
Copy link
Contributor Author

Simbiat commented Feb 29, 2020

Did not even notice it was there in the field even :D But, yes, this seems to be the case. Although, I am not sure it's correct to have "on update CURRENT_TIMESTAMP" in the "Attributes" field, because you may need both, say, UNSIGNED and "on update". I am also not sure, whether "CURRENT_TIMESTAMP" is the only possible clause for "on update", although was not able to google anything proving that.

@williamdes
Copy link
Member

Except the bug do you have comments on the previous message @OlafvdSpek?

@OlafvdSpek
Copy link

on update current_timestamp is available for datetime and timestamp columns (and maybe others) but not for columns where binary or unsigned are available.

As far as I know current_timestamp is the only option available for on update.

@iifawzi
Copy link
Contributor

iifawzi commented Feb 15, 2021

is this bug still exists? seems like it's already fixed. as i'm not able to re-produce the bug with the current version.

@Simbiat
Copy link
Contributor Author

Simbiat commented Feb 15, 2021

@iifawzi this is replicable in 5.1.0-rc2, at least. Just follow the steps described in original post. The issue here is that "EXTRA" is not showed by "Edit Column" UI at all (yet, AUTO_INCREMENT is preserved somehow).

@williamdes williamdes added the has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete label Feb 15, 2021
@williamdes williamdes added this to the 5.1.0 milestone Feb 15, 2021
@williamdes williamdes self-assigned this Feb 16, 2021
williamdes added a commit that referenced this issue Feb 16, 2021
Signed-off-by: William Desportes <williamdes@wdes.fr>
williamdes added a commit that referenced this issue Feb 16, 2021
It was lowercase on MariaDB 10.4

Signed-off-by: William Desportes <williamdes@wdes.fr>
issues automation moved this from to be fixed soon to Closed Feb 16, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug A problem or regression with an existing feature has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete
Projects
issues
  
Closed
4 participants