Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setup doc links broken (w/fix) #15996

Closed
hcoin opened this issue Feb 26, 2020 · 5 comments
Closed

setup doc links broken (w/fix) #15996

hcoin opened this issue Feb 26, 2020 · 5 comments
Assignees
@williamdes
Labels
Bug A problem or regression with an existing feature
Projects
Questions
Milestone
5.0.3

Comments

@hcoin
Copy link

hcoin commented Feb 26, 2020

In current stable, unchanged from the main download page:

On the various ~/setup screens there are blue circle links to related docs. These reside in the ~/doc directory, however during setup the links refer to /setup/doc which doesn't exist and so none of the docs are actually available.

Solution:
Add a symbolic link to ~/doc in ~/setup/doc
or fix all the references in ~/setup/*

OS: Ubuntu/eoan, nginx, (phpmyadmin not using the distro version, but rather the stable version off the main webpage), and firefox.
@williamdes
Copy link
Member

Hello @hcoin
Can you share a screenshot and let us know the version you are using ?

@williamdes williamdes added the question Used when we need feedback from the submitter or when the issue is a question about PMA label Feb 28, 2020
@williamdes williamdes added this to Needs triage in Questions via automation Feb 28, 2020
@williamdes williamdes moved this from Needs triage to Needs a second check to be a bug in Questions Feb 28, 2020
@ibennetch
Copy link
Member

ibennetch commented Apr 5, 2020 •
edited

Confirmed, thanks for reporting.

This broke somewhere between 4.9 and 5.0 but I'm having a bit of trouble using git bisect to find where exactly, because it broke in several different ways (at one point, paths became relative to the location on disk, at one point rendering the page broke completely). So I'm still looking in to how this happened, but it definitely seems broken to me.

@williamdes williamdes added Bug A problem or regression with an existing feature and removed question Used when we need feedback from the submitter or when the issue is a question about PMA labels Apr 5, 2020
@williamdes williamdes added this to the 5.0.3 milestone Apr 5, 2020
@williamdes
Copy link
Member

image

By "Check my links" for Chrome

@williamdes
Copy link
Member

Add a symbolic link to ~/doc in ~/setup/doc

I will not use this option because of #16033 (#16034)
Some users need more permissions for symlinks to be extracted

@williamdes williamdes self-assigned this May 17, 2020
williamdes added a commit that referenced this issue May 17, 2020
@williamdes
Add a ChangeLog entry for #15996
13f04e5 
Signed-off-by: William Desportes <williamdes@wdes.fr>
@ibennetch
Copy link
Member

Thanks @williamdes, nice work!

williamdes added a commit that referenced this issue May 18, 2020
@williamdes
Fix #15996 - local setup doc links are broken, us the right links in …
7032972 
…FormDisplay

Signed-off-by: William Desportes <williamdes@wdes.fr>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@williamdes williamdes

Labels
Bug A problem or regression with an existing feature
Projects
Questions
  
Needs a second check to be a bug
Milestone
5.0.3
Development

No branches or pull requests
3 participants
@ibennetch @hcoin @williamdes