Auto saved query no longer loading

[darrentayloruk]

Describe the bug

The get auto-saved query button always shows the message

"No previously auto-saved query is available. Loading default query."

Rather than loading a previous query

To Reproduce

Steps to reproduce the behavior:

1. Login to PMA
2. Go to the SQL tab for a particular table
3. Write and run an SQL statement
4. Return to the SQL tab and press "Get auto-saved query"
5. Message prompt "No previously auto-saved query is available. Loading default query."

Expected behavior

On pressing Get auto-saved query it should load the previous query that was created and ran

Screenshots

Initial Error

I can see the SQL being written into localStorage as I type

But on submitting a query I can see this value is removed in /js/vendor/sql.js

Server configuration

• Operating system: Linux
• Web server: Apache/2.4.38 (Debian)
• PHP version: 7.4.1
• phpMyAdmin version: 5.0.1

Client configuration

• Browser: Firefox 73.0.1 (64-bit)
• Operating system: Windows 10

[williamdes]

Confirmed, I tested on 4.9 and it worked fine.
Investigating..

[williamdes]

Introduced by 9c7c5ca in #14166

@Piyush3079 do you know if you did introduce a regression by trying to fix #14093 ?

[williamdes]

@MauricioFauth could I have your advice on this one ?

[Bllacky]

Just tried this on version 5.0.2 and still not working. Not sure when it got broken, but it was working a few months ago.

[williamdes]

It was broken since 5.0.0 alpha 1
I need some feedback to know if I can revert the change I mentioned or if it was expected in some way

[darrentayloruk]

I've had a read over the commits and it's this change here:
"deleting auto_saved_sql on clicking submit query button "
6a44368#diff-330ef13a94973fd5d1aefa611e91b23eR451

Which was clearly intended, but I'm not yet clear on why it was needed as seems to be the breaker of this function.

I've commented out that code in a local version and can restore the previous query when switching been tabs/functions within the same table. Which is very handy, saves me most time and covers most my use case. I'll continue testing it.

I think there is somewhere else clearing it if I switch to another table, will look for it.

Let me know if I can help in any other way

[williamdes]

Let me know if I can help in any other way

If you find the other piece of code that clears the storage I would be interested to know where to find it

@ibennetch could you give your point of view on this issue ?

[darrentayloruk]

Yep it appears to be here

phpmyadmin/js/ajax.js

Line 269 in b2d1615

if (isStorageSupported('localStorage')) {

On navigate away asks for confirmation and clears it

[shucon]

@williamdes from what I remember, it might be a regression. There were a lot of bugs fixed in #14166 , the intention for removing the saved query was that page change should not show query from another page as mentioned here: https://github.com/phpmyadmin/phpmyadmin/pull/14094/files

[shucon]

Should I go ahead and fix this?

[Bllacky]

Please fix this! I used the Auto-save function extensively as it improves productivity.

[williamdes]

This will be fixed in 5.1.0 ! 🚀

[MatthiasNZ]

Just installed 5.1.0

Queries are still not auto-saved!

[williamdes]

Just installed 5.1.0

Queries are still not auto-saved!

I often use the query saving feature, it works
Could you describe how you are using the feature please?

[MatthiasNZ]

@williamdes :

1. I type a simple query, like SELECT * FROM MyTable WHERE <some condition> into the SQL tab: result appears fine.
2. Then click on some other table in the table navigation panel (LH side), which defaults to BROWSE (i.e. SELECT * FROM MyNewTable).
3. I then click on the SQL tab again. "Get auto-saved query" : produces the message "No previously auto-saved query is available..."

This used to work fine in earlier versions (not sure exactly which)

[williamdes]

This used to work fine in earlier versions (not sure exactly which)

Could you find what version this was ?

result appears fine.

If you do not run the query and for example click on another database the save feature will work