Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Input elements should have autocomplete attributes #16001

Closed
williamdes opened this issue Feb 27, 2020 · 8 comments
Closed

Input elements should have autocomplete attributes #16001

williamdes opened this issue Feb 27, 2020 · 8 comments
Assignees
@williamdes
Labels
enhancement A feature request for improving phpMyAdmin good first issue has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete newbie ui Issues relating to the user interface
Projects
Enhancements
Milestone
5.1.0

Comments

@williamdes
Copy link
Member

https://www.chromium.org/developers/design-documents/create-amazing-password-forms

https://www.chromium.org/developers/design-documents/form-styles-that-chromium-understands

1582843084400:DEBUG:http://127.0.0.1:8000/server_privileges.php?adduser=1 - [DOM] Input elements should have autocomplete attributes (suggested: "new-password"): (More info: https://goo.gl/9p2vKq) %o
@williamdes williamdes added enhancement A feature request for improving phpMyAdmin newbie ui Issues relating to the user interface good first issue labels Feb 27, 2020
@williamdes williamdes added this to the 5.1.0 milestone Feb 27, 2020
@williamdes williamdes added this to Triage zone in Enhancements via automation Feb 27, 2020
@williamdes williamdes moved this from Triage zone to Nice to have soon in Enhancements Feb 27, 2020
@Pankaj-Wadhwani
Copy link
Contributor

Can I work on this?

@williamdes
Copy link
Member Author

Yes, go ahead @Pankaj-Wadhwani
Please use master branch and do not forget to use --signoff option to add your signoff line in the commit body, please use your real name (this option is an agreement to our policy)

@Pankaj-Wadhwani
Copy link
Contributor

This is my very first contribution can you please guide me with the steps that how should i proceed

@williamdes
Copy link
Member Author

This is my very first contribution can you please guide me with the steps that how should i proceed

To contribute I would suggest to follow:

  • Fork the repository
  • Clone the fork locally into a web folder eg:/var/www
  • Checkout master branch since it is an enhancement and create a new branch from master
  • Run yarn install
  • Run composer install
  • Create a config.inc.php if needed using the example file
  • Access your phpmyadmin website and login
  • Start developing the feature
  • Commit and push your changes and open a pull-request to this repository, branch: master

Is this okay for you ?

@Pankaj-Wadhwani
Copy link
Contributor

yes,thanks.

@Pankaj-Wadhwani
Copy link
Contributor

Please review my pull request @williamdes

@MauricioFauth MauricioFauth mentioned this issue Mar 4, 2020
Merged
6 tasks
@MauricioFauth MauricioFauth linked a pull request Mar 4, 2020 that will close this issue
autocomplete attributes added #16011
Merged
6 tasks
@MauricioFauth MauricioFauth removed a link to a pull request Mar 4, 2020
autocomplete attributes added #16011
Merged
6 tasks
@williamdes williamdes added the has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete label Mar 4, 2020
williamdes added a commit that referenced this issue Mar 10, 2020
@williamdes
Add ChangeLog entry for #16001
e6e2f1e 
Signed-off-by: William Desportes <williamdes@wdes.fr>
williamdes added a commit that referenced this issue Mar 10, 2020
@williamdes
#16001 - add autocomplete attributes on signon example
3ff5a46 
Signed-off-by: William Desportes <williamdes@wdes.fr>
Enhancements automation moved this from Nice to have soon to Done Mar 10, 2020
@williamdes williamdes self-assigned this Mar 10, 2020
@williamdes
Copy link
Member Author

one-time-code could be used for 2FA codes but I am not sure about it because we use off for now

@williamdes
Copy link
Member Author

https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes/autocomplete

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@williamdes williamdes

Labels
enhancement A feature request for improving phpMyAdmin good first issue has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete newbie ui Issues relating to the user interface
Projects
Enhancements
  
Done
Milestone
5.1.0
Development

No branches or pull requests
2 participants
@williamdes @Pankaj-Wadhwani