Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove/replace all symbolic links #16033

Closed
mvorisek opened this issue Jan 8, 2020 · 5 comments
Closed

Remove/replace all symbolic links #16033

mvorisek opened this issue Jan 8, 2020 · 5 comments
Assignees
@williamdes
Labels
enhancement A feature request for improving phpMyAdmin
Projects
Enhancements
Milestone
5.0.2

Comments

@mvorisek
Copy link
Contributor

mvorisek commented Jan 8, 2020

Symbolic links are not normally supported on Windows, see release extraction log:

! Cannot create symbolic link ...\phpMyAdmin-5.0.1-english\vendor\bin\highlight-query
! You may need to run WinRAR as administrator
  A required privilege is not held by the client.
! Cannot create symbolic link ...\phpMyAdmin-5.0.1-english\vendor\bin\lint-query
! You may need to run WinRAR as administrator
  A required privilege is not held by the client.
! Cannot create symbolic link ...\phpMyAdmin-5.0.1-english\vendor\bin\tokenize-query
! You may need to run WinRAR as administrator
  A required privilege is not held by the client.

Symbolic links are often also disable in Apache config.

Analyse if the symbolic links are used and remove them or replace them with another solution.
@williamdes williamdes transferred this issue from phpmyadmin/phpmyadmin Jan 8, 2020
@williamdes
Copy link
Member

@mvorisek I moved this issue to the sql-parser repo, the symlinks are created by composer and are not usefull for using phpMyAdmin in production mode
https://github.com/phpmyadmin/sql-parser/blob/bddaf056f8f43621e94b29284c98f35db8b6d93e/composer.json#L38-L42

@mvorisek
Copy link
Contributor Author

mvorisek commented Jan 8, 2020

@williamdes Yes, they are created by composer and the links should be deleted in the phpmyadmin release/build script.

@williamdes
Copy link
Member

@ibennetch what do you think about that ?

@williamdes williamdes transferred this issue from phpmyadmin/sql-parser Mar 19, 2020
@williamdes williamdes added the enhancement A feature request for improving phpMyAdmin label Mar 19, 2020
@williamdes williamdes added this to Triage zone in Enhancements via automation Mar 19, 2020
@williamdes williamdes moved this from Triage zone to Miscellaneous in Enhancements Mar 19, 2020
@williamdes williamdes added this to the 5.0.2 milestone Mar 19, 2020
@williamdes williamdes self-assigned this Mar 19, 2020
williamdes added a commit to williamdes/phpmyadmintest that referenced this issue Mar 19, 2020
@williamdes
Add ChangeLog entry for phpmyadmin#16033
ab43e7a 
Signed-off-by: William Desportes <williamdes@wdes.fr>
@williamdes williamdes mentioned this issue Mar 19, 2020
Merged
@williamdes
Copy link
Member

I opened #16034 to fix this behavior

@ibennetch
Copy link
Member

I agree. This is harmless behavior and the warning/error can be disregarded, but I think we can discard these as part of creating the release.

williamdes added a commit to williamdes/phpmyadmintest that referenced this issue Mar 19, 2020
@williamdes
Merge phpmyadmin#16034 - Fix phpmyadmin#16033 Remove composer bin files
abcf875 
Pull-request: phpmyadmin#16034
Fixes: phpmyadmin#16033
Signed-off-by: William Desportes <williamdes@wdes.fr>
Enhancements automation moved this from Miscellaneous to Done Mar 19, 2020
@williamdes williamdes mentioned this issue May 17, 2020
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@williamdes williamdes

Labels
enhancement A feature request for improving phpMyAdmin
Projects
Enhancements
  
Done
Milestone
5.0.2
Development

No branches or pull requests
3 participants
@ibennetch @mvorisek @williamdes