New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JS error on mousemove, $.throttle #16052
Comments
|
@DavidThomas48 , would it be please possible to get the screenshot of the whole page with the errors displayed? |
|
Hi Hugues,
If it happens again I will do that. I can tell you that it happens when I resize the Routines editor dialog.
David
|
|
Hello Hugues ,
I just experienced the problem and it happened when I dragged the divider to the right to widen the left sidebar (database navigation tree). I had previously dragged it left to make the sidebar very narrow, then done some other things.
My previous comment about it being related to the routines dialog may be incorrect. I think I may not have noticed the error for a moment, and started using the routine editor dialog in the meantime. I hope that comment has not been a distraction - if so I apologise.
Hope that helps.
David
|
|
Hi again, |
|
Reading the code it seems like |
|
@DavidThomas48 does this patch solve this issue for you ? diff --git a/js/navigation.js b/js/navigation.js
index 169d4e40592..43f104ce2f9 100644
--- a/js/navigation.js
+++ b/js/navigation.js
@@ -1298,10 +1298,12 @@ Navigation.ResizeHandler = function () {
*/
this.mousemove = function (event) {
event.preventDefault();
- var pos = event.data.resize_handler.getPos(event);
- event.data.resize_handler.setWidth(pos);
- if ($('.sticky_columns').length !== 0) {
- Sql.handleAllStickyColumns();
+ if (event.data.resize_handler) {
+ var pos = event.data.resize_handler.getPos(event);
+ event.data.resize_handler.setWidth(pos);
+ if ($('.sticky_columns').length !== 0) {
+ Sql.handleAllStickyColumns();
+ }
}
};
/** |
|
Hello William,
I am working on a WordPress site that contains only one copy of navigation.js which is only 3.66Kb and does not contain Navigation.ResizeHandler = function () {…
I should add that the error happens very rarely – I had not seen it for well over a month until the other day and I am working in pma every day.
Regards
David Thomas
|
|
Sorry William – senior moment – just making the patch now but I really won’t know if it has fixed the problem because of the rarity of the error.
DT
|
|
Hi From what you commented I can understand you where probably no up to date :) |
|
I have installed the patch on my server. If the error hasn’t happened by August, it’s probably fixed!
D
|
|
I just realised, I have been working online with a host site recently, and they are running pma 4.9.1. I am fairly sure that the error occurred on my machine (pma 5.0.2), but it is possible that the error occurred on that site. Sorry to be vague about this. Doesn’t the error report give you the pma version?
David
|
|
Indeed, I got confused but you where running 5.0.1 when you reported this issue, I will commit the patch ASAP then William |
|
Hi William,
I just had the error again but this was definitely in pma 4.9.1. I noticed that the error report includes the pma version. Just to be sure, if you still have my earlier report, please check whether that error happened in 5.0.2 or 4.9.1 - I am working on both at the moment.
All the best
David
|
Signed-off-by: William Desportes <williamdes@wdes.fr>
|
Hi, Kind regards, |
Describe the bug
js error message on screen
To Reproduce
can't
Expected behavior
Screenshots
If applicable, add screenshots to help explain your problem.

Server configuration
Win10 64 XAMPP
Client configuration
Chrome
Additional context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered: