Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JS error on mousemove, $.throttle #16052

Closed
DavidThomas48 opened this issue Mar 28, 2020 · 14 comments
Closed

JS error on mousemove, $.throttle #16052

DavidThomas48 opened this issue Mar 28, 2020 · 14 comments
Assignees
Labels
Bug A problem or regression with an existing feature
Projects
Milestone

Comments

@DavidThomas48
Copy link

Describe the bug

js error message on screen

To Reproduce

can't

Expected behavior

Screenshots

If applicable, add screenshots to help explain your problem.
image

image

Server configuration

Win10 64 XAMPP

Client configuration

Chrome

Additional context

Add any other context about the problem here.

@williamdes williamdes added the Bug A problem or regression with an existing feature label Mar 28, 2020
@williamdes williamdes modified the milestones: 5.1.0, 5.0.3 Mar 28, 2020
@williamdes williamdes added this to Needs triage in issues via automation Mar 28, 2020
@Tithugues
Copy link
Contributor

@DavidThomas48 , would it be please possible to get the screenshot of the whole page with the errors displayed?
Can you please confirm that you have the error on the home page?

@DavidThomas48
Copy link
Author

DavidThomas48 commented Apr 14, 2020 via email

@DavidThomas48
Copy link
Author

DavidThomas48 commented Apr 16, 2020 via email

@DavidThomas48
Copy link
Author

Hi again,
Re "Can you please confirm that you have the error on the home page?" - no this is not the case. It happens when I am working in tables or routines. I am rarely on the home page.

@williamdes williamdes moved this from Needs triage to Not reproduced in issues Apr 16, 2020
@williamdes
Copy link
Member

Reading the code it seems like js/vendor/jquery/jquery.debounce-1.0.5.js did throttle the call and then invoke it but forgetting the event data

@williamdes williamdes changed the title JS error JS error on mousemove Jun 7, 2020
@williamdes
Copy link
Member

@DavidThomas48 does this patch solve this issue for you ?

diff --git a/js/navigation.js b/js/navigation.js
index 169d4e40592..43f104ce2f9 100644
--- a/js/navigation.js
+++ b/js/navigation.js
@@ -1298,10 +1298,12 @@ Navigation.ResizeHandler = function () {
      */
     this.mousemove = function (event) {
         event.preventDefault();
-        var pos = event.data.resize_handler.getPos(event);
-        event.data.resize_handler.setWidth(pos);
-        if ($('.sticky_columns').length !== 0) {
-            Sql.handleAllStickyColumns();
+        if (event.data.resize_handler) {
+            var pos = event.data.resize_handler.getPos(event);
+            event.data.resize_handler.setWidth(pos);
+            if ($('.sticky_columns').length !== 0) {
+                Sql.handleAllStickyColumns();
+            }
         }
     };
     /**

@williamdes williamdes changed the title JS error on mousemove JS error on mousemove, $.throttle Jun 7, 2020
@DavidThomas48
Copy link
Author

DavidThomas48 commented Jun 8, 2020 via email

@DavidThomas48
Copy link
Author

DavidThomas48 commented Jun 8, 2020 via email

@williamdes
Copy link
Member

Hi

From what you commented I can understand you where probably no up to date :)
I am not sure that I will post my patch, can you let me know if you where using a 5.0 version?

@DavidThomas48
Copy link
Author

DavidThomas48 commented Jun 8, 2020 via email

@DavidThomas48
Copy link
Author

DavidThomas48 commented Jun 8, 2020 via email

@williamdes
Copy link
Member

Indeed, I got confused but you where running 5.0.1 when you reported this issue, I will commit the patch ASAP then

William

@DavidThomas48
Copy link
Author

DavidThomas48 commented Jun 10, 2020 via email

@williamdes williamdes self-assigned this Jun 10, 2020
williamdes added a commit that referenced this issue Jun 10, 2020
Signed-off-by: William Desportes <williamdes@wdes.fr>
@williamdes
Copy link
Member

Hi,
I committed 9b66cf1 to fix the issue you reported.
I hope it will be okay to fix this issue

Kind regards,
William

issues automation moved this from Not reproduced to Closed Jun 10, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug A problem or regression with an existing feature
Projects
issues
  
Closed
Development

No branches or pull requests

3 participants