getData returns array of strings instead of array of arrays when DisableIS === True

[simonvik]

Describe the bug

public function getData($type, $pos, $searchClause = '') in libraries/classes/Navigation/Nodes/NodeTable.php

returns an array of strings instead of an array of arrays if DisableIS is true, that makes

getDisplayName in libraries/classes/Navigation/Nodes/NodeColumn.php fail as it expects an array.

Server configuration

• phpMyAdmin version: trunk

Additional context

We've made a temporary patch that looks like:

diff -ur phpMyAdmin-5.0.2-all-languages_orig/libraries/classes/Navigation/Nodes/NodeTable.php phpMyAdmin-5.0.2-all-languages/libraries/classes/Navigation/Nodes/NodeTable.php
--- phpMyAdmin-5.0.2-all-languages_orig/libraries/classes/Navigation/Nodes/NodeTable.php	2020-03-21 04:17:40.000000000 +0000
+++ phpMyAdmin-5.0.2-all-languages/libraries/classes/Navigation/Nodes/NodeTable.php	2020-05-18 09:35:32.167217990 +0000
@@ -194,7 +194,13 @@
                 if ($GLOBALS['dbi']->dataSeek($handle, $pos)) {
                     while ($arr = $GLOBALS['dbi']->fetchArray($handle)) {
                         if ($count < $maxItems) {
-                            $retval[] = $arr['Field'];
+                            $retval[] = array(
+                                'name' => $arr['Field'],
+                                'key' => $arr['Key'],
+                                'type' => $arr['Type'],
+                                'default' =>  $arr['Default'],
+                                'nullable' => ($arr['Null'] == 'NO' ? '' : 'nullable')
+                            );
                             $count++;
                         } else {
                             break;

[williamdes]

phpMyAdmin version: trunk: phpMyAdmin version: 5.0.2

Thank you for the report !

[williamdes]

@simonvik Could you send screenshots of the impact of this change ?

[simonvik]

Before patch

After patch

Note that SHOW COLUMNS FROM is slightly more verbose than SELECT DATA_TYPE FROM INFORMATION_SCHEMA WHERE ...

It shows the length of int, varchar

[williamdes]

Seems like it was forgot in #14910

Here is the patch I committed in 481023e

diff --git a/libraries/classes/Navigation/Nodes/NodeTable.php b/libraries/classes/Navigation/Nodes/NodeTable.php
index 89965ebc0d..0790c57cb5 100644
--- a/libraries/classes/Navigation/Nodes/NodeTable.php
+++ b/libraries/classes/Navigation/Nodes/NodeTable.php
@@ -194,7 +194,13 @@ class NodeTable extends NodeDatabaseChild
                 if ($GLOBALS['dbi']->dataSeek($handle, $pos)) {
                     while ($arr = $GLOBALS['dbi']->fetchArray($handle)) {
                         if ($count < $maxItems) {
-                            $retval[] = $arr['Field'];
+                            $retval[] = [
+                                'name' => $arr['Field'],
+                                'key' => $arr['Key'],
+                                'type' => Util::extractColumnSpec($arr['Type'])['type'],
+                                'default' =>  $arr['Default'],
+                                'nullable' => ($arr['Null'] === 'NO' ? '' : 'nullable'),
+                            ];
                             $count++;
                         } else {
                             break;

this issue will be fixed in the next version, thank you a lot for the patch It took me less time to fix the issue.