Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When browsing, changing the sort order loses the number of rows setting #16146

Closed
DavidThomas48 opened this issue May 29, 2020 · 1 comment
Closed

When browsing, changing the sort order loses the number of rows setting #16146

DavidThomas48 opened this issue May 29, 2020 · 1 comment
Assignees
@williamdes
Labels
Bug A problem or regression with an existing feature good first issue has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete
Projects
issues
Milestone
5.0.3

Comments

@DavidThomas48
Copy link

When browsing, changing the sort order looses the number of rows setting

To Reproduce

select a list of records
change the number of rows to say 500
change the sort order of the list

Expected behavior

Don't change the number of rows setting when the sort order is changed

image

  • Browser: Chrome
  • Operating system: W10 64
@williamdes williamdes added the Bug A problem or regression with an existing feature label Jun 3, 2020
@williamdes williamdes added this to Needs triage in issues via automation Jun 3, 2020
@williamdes williamdes moved this from Needs triage to to be fixed soon in issues Jun 3, 2020
@williamdes williamdes added this to the 5.0.3 milestone Jun 3, 2020
@DavidThomas48 DavidThomas48 changed the title When browsing, changing the sort order looses the number of rows setting When browsing, changing the sort order loses the number of rows setting Jul 15, 2020
@rajat315315 rajat315315 mentioned this issue Jul 22, 2020
Merged
6 tasks
@williamdes williamdes added the has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete label Jul 22, 2020
@williamdes williamdes self-assigned this Jul 23, 2020
@williamdes
Copy link
Member

Reproduced, thank you for reporting it @DavidThomas48

williamdes added a commit that referenced this issue Jul 23, 2020
@williamdes
Merge #16275 - Fix #16146 - sorting does not keep the number of rows …
54efb1e 
…selector

Signed-off-by: William Desportes <williamdes@wdes.fr>
williamdes added a commit that referenced this issue Jul 23, 2020
@williamdes
Add a ChangeLog entry for #16146
3891a08 
Signed-off-by: William Desportes <williamdes@wdes.fr>
williamdes added a commit that referenced this issue Jul 23, 2020
@williamdes
Fallback on empty string for #16146 if session_max_rows is not set
38c09bc 
Signed-off-by: William Desportes <williamdes@wdes.fr>
issues automation moved this from to be fixed soon to Closed Jul 23, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@williamdes williamdes

Labels
Bug A problem or regression with an existing feature good first issue has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete
Projects
issues
  
Closed
Milestone
5.0.3
Development

No branches or pull requests
2 participants
@DavidThomas48 @williamdes