PHP notice - Undefined index: column_info

[williamdes]

Describe the bug

Php notice

To Reproduce

Notice in ./libraries/classes/SystemDatabase.php#63
 Undefined index: column_info

Backtrace

./view_create.php#150: PhpMyAdmin\SystemDatabase->getExistingTransformationData(string 'xxxxxxx')

Server configuration

• phpMyAdmin version: 5.0.3-dev

Target branch: QA_5_0

[olumide95]

Can you please elaborate on what the issue is?

[williamdes]

I think this issue reflects a lack of checking that

phpmyadmin/libraries/classes/RelationCleanup.php

Line 58 in a320294

if ($cfgRelation['commwork']) {

Because this piece of code does the isset and access check :

phpmyadmin/libraries/classes/Relation.php

Lines 628 to 635 in a320294

	if (isset($cfgRelation['column_info'])) {
	if ($this->canAccessStorageTable($cfgRelation['column_info'])) {
	$cfgRelation['commwork'] = true;
	// phpMyAdmin 4.3+
	// Check for input transformations upgrade.
	$cfgRelation['mimework'] = $this->tryUpgradeTransformations();
	}
	}

It should be done

phpmyadmin/libraries/classes/SystemDatabase.php

Lines 60 to 65 in a320294

	$pma_transformation_sql = sprintf(
	"SELECT * FROM %s.%s WHERE `db_name` = '%s'",
	Util::backquote($cfgRelation['db']),
	Util::backquote($cfgRelation['column_info']),
	$GLOBALS['dbi']->escapeString($db)
	);

Or maybe on the call of:

phpmyadmin/view_create.php

Line 155 in d2c8039

$new_transformations_sql = $systemDb->getNewTransformationDataSql(

I am not too much sure about if the fix should be in view_create.php or in getNewTransformationDataSql