Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please enter a valid number. #16201

Closed
OlafvdSpek opened this issue Jun 17, 2020 · 9 comments
Closed

Please enter a valid number. #16201

OlafvdSpek opened this issue Jun 17, 2020 · 9 comments
Assignees
Labels
Bug A problem or regression with an existing feature good first issue has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete newbie ui Issues relating to the user interface
Projects
Milestone

Comments

@OlafvdSpek
Copy link

OlafvdSpek commented Jun 17, 2020

"2710 " (note the space) isn't considered a valid number, by the client-side validator. I think the server-side code does consider this valid..

The error message is missing margins. Or is it padding?

image

@williamdes williamdes added Bug A problem or regression with an existing feature good first issue newbie ui Issues relating to the user interface labels Jun 17, 2020
@williamdes
Copy link
Member

The change must be done in

function verifyAfterSearchFieldChange (index) {
and using the target branch QA_5_0

@jabbarn
Copy link
Contributor

jabbarn commented Jun 18, 2020

Hi there @OlafvdSpek, what are the reproduction steps? Does this happen when you insert a number into a row?

@williamdes
Copy link
Member

hi @DaemonicNaymon

You need to enter a space after the number, only a front-end check to improve

@jabbarn
Copy link
Contributor

jabbarn commented Jun 18, 2020

Hi @williamdes

I've tried entering a space before after and between numbers but it just passes through so I'm wondering if the problem lays with my setup? 🤔

@OlafvdSpek
Copy link
Author

https://demo.phpmyadmin.net/master/index.php?route=/table/search&db=mysql&table=user

Enter 1, space into an int field, then move focus to another field.

@shahlin
Copy link
Contributor

shahlin commented Jun 21, 2020

@williamdes Which is the expected solution?

  1. Trim spaces automatically for INT types
  2. The padding must be increased for the error message
  3. Both

@williamdes
Copy link
Member

@williamdes Which is the expected solution?

  1. Trim spaces automatically for INT types
  2. The padding must be increased for the error message
  3. Both

I would say trim, having spaces has no sense for an int

@williamdes williamdes added the has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete label Jun 22, 2020
williamdes added a commit that referenced this issue Jun 22, 2020
Signed-off-by: William Desportes <williamdes@wdes.fr>
@williamdes williamdes self-assigned this Jun 22, 2020
@williamdes williamdes added this to the 5.0.3 milestone Jun 22, 2020
@williamdes williamdes added this to Needs triage in issues via automation Jun 22, 2020
@williamdes williamdes moved this from Needs triage to Closed in issues Jun 22, 2020
@OlafvdSpek
Copy link
Author

Don't forget the padding. ;)

@williamdes
Copy link
Member

@OlafvdSpek do you mean for the error message ?
can you open an issue for the master branch ?

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug A problem or regression with an existing feature good first issue has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete newbie ui Issues relating to the user interface
Projects
issues
  
Closed
Development

No branches or pull requests

4 participants