Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON input transformation editor is very narrow #16223

Closed
DavidHopkinsFbr opened this issue Jun 24, 2020 · 1 comment
Closed

JSON input transformation editor is very narrow #16223

DavidHopkinsFbr opened this issue Jun 24, 2020 · 1 comment
Assignees
Labels
enhancement A feature request for improving phpMyAdmin has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete ui Issues relating to the user interface
Milestone

Comments

@DavidHopkinsFbr
Copy link

DavidHopkinsFbr commented Jun 24, 2020

Describe the bug

When using the table Insert UI with the "JSON (text/plain)" input transformation, the provided editor window is very narrow compared to standard text field entries.

To Reproduce

Steps to reproduce the behavior:

  1. Create a table with a LONGTEXT column with "Browser display transformation" set to "JSON (text/plain: JSON)" and "Input transformation" set to "JSON (text/plain: JsonEditor)". Create a second column of varchar(255) or TEXT type.
  2. Click on 'Insert'
  3. Observe that the JSON editor box is extremely narrow compared to other long-text fields.

Expected behavior

I'd expect that JSON fields would be given about the same amount of UI width and height as other long-text types. A pretty-printed JSON structure is likely to have reasonable line lengths and a non-pretty-printed JSON literal will likely be quite wide.

Screenshots

image

Server configuration

Operating system: Windows 10 Pro 1809 LTSC
Web server: Apache 2.4.43
Database version: MariaDB 10.4.13
PHP version: 7.4.7
phpMyAdmin version: 5.0.2
Apache, MariaDB, PHP and phpmyadmin are installed via XAMPP 7.4.7, Win x64 version.

Client configuration

Browser: Reproduced in Chrome and Chromium Edge 83 and IE 11
Operating system: Win 10 1809 LTSC

@williamdes williamdes added enhancement A feature request for improving phpMyAdmin ui Issues relating to the user interface labels Jun 24, 2020
@williamdes williamdes added this to Triage zone in Enhancements via automation Jun 24, 2020
@williamdes
Copy link
Member

Thank you for the report :)

@williamdes williamdes added the has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete label Jun 29, 2020
@williamdes williamdes added this to the 5.1.0 milestone Jun 29, 2020
@williamdes williamdes self-assigned this Jul 2, 2020
williamdes added a commit that referenced this issue Jul 4, 2020
…y narrow

Merge: #16238
Fixes: #16223
Signed-off-by: William Desportes <williamdes@wdes.fr>
Enhancements automation moved this from Triage zone to Done Jul 4, 2020
williamdes added a commit that referenced this issue Jul 4, 2020
Signed-off-by: William Desportes <williamdes@wdes.fr>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement A feature request for improving phpMyAdmin has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete ui Issues relating to the user interface
Projects
Enhancements
  
Done
Development

No branches or pull requests

2 participants