Autocomplete is not working in case table name quoted by "`" symbols

[Jay04653]

To Reproduce

Steps to reproduce the behavior:

1. Try to write select query with table names in quotation
2. Autocomplete is not working, see screenshots below

Expected behavior

Autocomplete has to work in both cases

Screenshots

Working without quotation

Not working with quotation

Server configuration

• Operating system: Ubuntu 18.04
• Web server: Apache 2.4
• Database version: MySQL 5/8
• PHP version: 7.4
• phpMyAdmin version: 5.0.2

Client configuration

• Browser: Google Chrome
• Operating system: Ubuntu 20.04

[anksh1997]

Hi @williamdes @Jay04653
After digging deeper, I think the problem is with CodeMirror. An ajaxCall to db_sql_autocomplete.php is giving correct tables for both aliases with " ` " and without " ` ".
The problem is with sql-hint.js of the code mirror

https://github.com/codemirror/CodeMirror/blob/c0120793f1e9986b631411b6112e207866d3db81/addon/hint/sql-hint.js#L190

during finding eachWord what if codemirror just replaced " ` " also

We can raise issue in codemirror, if this is the real bug causing trouble

[Jay04653]

Hi @asprazz

Thank you for the debug!

It's really annoying because by default PHPMyAdmin displays tables with "`" and in case you need to add joins or filters you have to remove this quotation every time or just ignore an autocomplete feature and just type SQL query.

[williamdes]

Hi @asprazz !
Thank you for the debug, could you open an issue at CodeMirror and link it here ?

[anksh1997]

Ok @williamdes .

[anksh1997]

@Jay04653 If you are using development version of phpmyadmin, then you can edit Sql-Hint file in CodeMirror :)
A temparary fix, if it helps 😃

[Jay04653]

It was fixed on CodeMirror side, so now we can include this fix in the next PHPMyAdmin release.

[williamdes]

It was fixed on CodeMirror side, so now we can include this fix in the next PHPMyAdmin release.

Could you mention the version that fixed this issue ?

[Jay04653]

It was fixed on CodeMirror side, so now we can include this fix in the next PHPMyAdmin release.

Could you mention the version that fixed this issue ?

Seems it was fixed but not released yet :(

[nina-py]

@Jay04653 , @williamdes , I submitted a pull request (with a one-character change! :)) which was merged a couple of days ago. Looking at the releases history ( https://github.com/codemirror/CodeMirror/releases ), it seems that there's a new minor release on the 20th of each month, so we will have our fix on the 20th of October at the earliest.

[williamdes]

Very cool !
Links:

• codemirror/codemirror5@58c5534
• Fixes #6331. Backticks are stripped from SQL query words before comparison codemirror/codemirror5#6429

[shucon]

Related: #16314
Also a CodeMirror issue.

[shucon]

Ah, it's 20th October today as well. We might get a release today.

[williamdes]

https://github.com/codemirror/CodeMirror/releases/tag/5.58.2