Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failed Zoom search clears existing values #16245

Closed
ibennetch opened this issue Jul 2, 2020 · 1 comment
Closed

Failed Zoom search clears existing values #16245

ibennetch opened this issue Jul 2, 2020 · 1 comment
Assignees
@williamdes
Labels
Bug A problem or regression with an existing feature has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete
Projects
issues
Milestone
5.0.4

Comments

@ibennetch
Copy link
Member

Describe the bug

When using Zoom search (from a table, click Search then the "Zoom search" sub tab, the type, collation, and operator are dynamically updated when a column is selected.

If only one column is selected, phpMyAdmin tells me to "Select two columns". This warning disappears after two seconds, which I feel is too quickly, but anyway when it goes away the page loses the settings for the first column.

To Reproduce

  • Go to the Zoom search page.
  • Only fill in one column
  • Submit the form

Expected behavior

The data I've already entered should not disappear.

Server configuration

  • Operating system: Debian Linux
  • Web server: Apache 2.4
  • Database version: MariaDB 10.3.22
  • PHP version: 7.3.14
  • phpMyAdmin version: 5.0.2

Client configuration

  • Browser: Firefox 77
  • Operating system: MacOS
@williamdes williamdes added the Bug A problem or regression with an existing feature label Jul 2, 2020
@williamdes williamdes added this to Needs triage in issues via automation Jul 23, 2020
@williamdes williamdes moved this from Needs triage to to be fixed soon in issues Jul 23, 2020
@williamdes williamdes removed this from to be fixed soon in issues Jul 24, 2020
@williamdes williamdes added this to Needs triage in issues via automation Jul 24, 2020
@williamdes williamdes moved this from Needs triage to n/a priority in issues Jul 24, 2020
@petrduda
Copy link
Contributor

petrduda commented Oct 5, 2020

The same incorrect behavior can also be observed when two columns are selected correctly (with or without additional search criteria) - a result chart is displayed, but the previously entered settings in the search criteria section disappear.

@petrduda petrduda mentioned this issue Oct 5, 2020
Merged
6 tasks
@williamdes williamdes added this to the 5.0.4 milestone Oct 11, 2020
@williamdes williamdes added the has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete label Oct 11, 2020
@williamdes williamdes self-assigned this Oct 11, 2020
williamdes added a commit that referenced this issue Oct 11, 2020
@williamdes
Merge #16384 - Fix #16245 - Failed Zoom search clears existing values
c87576f 
Pull-request: #16384
Fixes: #16245

Signed-off-by: William Desportes <williamdes@wdes.fr>
williamdes added a commit that referenced this issue Oct 11, 2020
@williamdes
Add a ChangeLog entry for #16245 and 7c091b6
81e64f0 
Signed-off-by: William Desportes <williamdes@wdes.fr>
issues automation moved this from n/a priority to Closed Oct 13, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@williamdes williamdes

Labels
Bug A problem or regression with an existing feature has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete
Projects
issues
  
Closed
Milestone
5.0.4
Development

No branches or pull requests
3 participants
@ibennetch @williamdes @petrduda