Zoom Search is not performing input validation on INT columns

[anksh1997]

Describe the bug

When we are using zoom search on a table validations are failing because of the fix id of table search form in validation function.

To Reproduce

Steps to reproduce the behavior:

1. Select any table
2. Click on Search tabl
3. Click on Zoom Search subtab
4. Select any INT field in first / second row of first column
5. Enter invalid value in input field.

Expected behavior

It should display appropriate message after successful validation just like in table serach form.

Screenshots

Now

Expected After chaning id to zoom_search_form in validation function

pma_version: 5.0.3-dev
browser_name: CHROME
browser_version: 83.0.4103.116
user_os: Linux
server_software: Apache
php_version: 7.3.16

[ibennetch]

I edited the subject of this report.

Thank you for reporting.

[ibennetch]

With QA_5_0 I get this JavaScript error:

{
    "pma_version": "5.0.3-dev",
    "browser_name": "FIREFOX",
    "browser_version": "78.0",
    "user_os": "Mac",
    "server_software": "nginx/1.14.2",
    "user_agent_string": "Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:78.0) Gecko/20100101 Firefox/78.0",
    "locale": "en",
    "configuration_storage": "disabled",
    "php_version": "7.4.7",
    "script_name": "tbl_zoom_select.php",
    "exception_type": "js",
    "exception": {
        "mode": "stack",
        "name": "TypeError",
        "message": "$.data(...) is undefined",
        "stack": [
            {
                "func": "rules",
                "line": "164",
                "column": "17",
                "context": [
                    "\t\tif ( element.form == null ) {",
                    "\t\t\treturn;",
                    "\t\t}",
                    "",
                    "\t\tif ( command ) {",
                    "\t\t\tsettings = $.data( element.form, \"validator\" ).settings;",
                    "\t\t\tstaticRules = settings.rules;",
                    "\t\t\texistingRules = $.validator.staticRules( element );",
                    "\t\t\tswitch ( command ) {",
                    "\t\t\tcase \"add\":",
                    "\t\t\t\t$.extend( existingRules, $.validator.normalizeRule( argument ) );"
                ],
                "uri": "js/vendor/jquery/jquery.validate.js?v=5.0.3-dev",
                "scriptname": "js/vendor/jquery/jquery.validate.js"
            },
            {
                "func": "validateIntField",
                "line": "208",
                "column": "17",
                "context": [
                    " * @returns {void}",
                    " */",
                    "function validateIntField (jqueryInput, returnValueIfIsNumber) {",
                    "    var mini = parseInt(jqueryInput.data('min'));",
                    "    var maxi = parseInt(jqueryInput.data('max'));",
                    "    jqueryInput.rules('add', {",
                    "        number: {",
                    "            param: true,",
                    "            depends: function () {",
                    "                return returnValueIfIsNumber;",
                    "            }"
                ],
                "uri": "js/table/change.js?v=5.0.3-dev",
                "scriptname": "js/table/change.js"
            },
            {
                "func": "verifyAfterSearchFieldChange",
                "line": "174",
                "column": "29",
                "context": [
                    "            Messages.strEnterValidNumber",
                    "            );",
                    "            validateMultipleIntField($thisInput, true);",
                    "        } else {",
                    "            $('#tbl_search_form').validate();",
                    "            validateIntField($thisInput, true);",
                    "        }",
                    "    }",
                    "}",
                    "",
                    "/**"
                ],
                "uri": "js/table/change.js?v=5.0.3-dev",
                "scriptname": "js/table/change.js"
            },
            {
                "func": "onchange",
                "line": "1",
                "column": "8",
                "context": [
                    "",
                    "",
                    "",
                    "  ",
                    "  "
                ],
                "uri": "tbl_zoom_select.php?",
                "scriptname": "tbl_zoom_select.php"
            }
        ],
        "uri": "tbl_zoom_select.php?"
    }
}

With master, it just silently fails.

[anksh1997]

Can I work on this ? :)
I can think of a solution
we can pass searchType identifier in verifyAfterSearchFieldChange function to change id dynamically

[ibennetch]

Sure, you can work on it. Please target the QA_5_0 branch.