Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Font size too small when editing rows #16252

Closed
qcybb opened this issue Jul 9, 2020 · 9 comments · Fixed by #16370
Closed

Font size too small when editing rows #16252

qcybb opened this issue Jul 9, 2020 · 9 comments · Fixed by #16370
Assignees
@williamdes
Labels
enhancement A feature request for improving phpMyAdmin has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete ui Issues relating to the user interface
Projects
Enhancements
Milestone
5.1.0

Comments

@qcybb
Copy link

qcybb commented Jul 9, 2020

The font size is too small when editing rows in Chrome and the new Edge browser.

I don't remember the font ever being that small - it used to be the same size as the normal row text.

I'm using:
phpMyAdmin v4.9.5
Chrome v83.0.4103.116
Edge Chrome Browser v83.0.478.61

small-font-size
@williamdes
Copy link
Member

Hi @qcybb
Could you please try 5.0 ?

@williamdes williamdes added ui Issues relating to the user interface question Used when we need feedback from the submitter or when the issue is a question about PMA labels Jul 23, 2020
@williamdes williamdes added this to Needs triage in Questions via automation Jul 23, 2020
@williamdes williamdes moved this from Needs triage to Needs a second check to be a bug in Questions Jul 23, 2020
@williamdes williamdes moved this from Needs a second check to be a bug to waiting... in Questions Jul 23, 2020
@qcybb
Copy link
Author

qcybb commented Jul 23, 2020

Ok, I installed phpMyAdmin v5.0.2 and still have the issue.

screen-1

screen-2

@williamdes williamdes added enhancement A feature request for improving phpMyAdmin and removed question Used when we need feedback from the submitter or when the issue is a question about PMA labels Jul 23, 2020
@williamdes williamdes removed this from waiting... in Questions Jul 23, 2020
@williamdes williamdes added this to Triage zone in Enhancements via automation Jul 23, 2020
@williamdes williamdes moved this from Triage zone to Interface in Enhancements Jul 23, 2020
@williamdes
Copy link
Member

Thank you, I marked this one as an enhancement.

@qcybb
Copy link
Author

qcybb commented Jul 26, 2020

Using the web browsers developer tools, I see that removing "font-family: monospace" from "textarea" solves the issue.

I'm unable to fix this locally for my self, as these changes have to be made in the .scss file and then recompiled - and I do not have the necessary tools to do this.

@williamdes
Copy link
Member

@MauricioFauth so you have some opinions about removing the font from text areas?

@qcybb
Copy link
Author

qcybb commented Jul 27, 2020

By removing "font-family: monospace" from "textarea", it falls back to the sans-serif font and looks the same as the other input fields.

fixed

@rajat315315 rajat315315 mentioned this issue Sep 20, 2020
Merged
6 tasks
@rajat315315
Copy link
Contributor

Fixed.

@qcybb
Copy link
Author

qcybb commented Sep 20, 2020

Thanks!

@williamdes williamdes added the has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete label Jan 22, 2021
@williamdes williamdes added this to the 5.1.0 milestone Jan 22, 2021
@williamdes williamdes self-assigned this Jan 23, 2021
@williamdes
Copy link
Member

This fix will be part of 5.1.0

williamdes added a commit that referenced this issue Jan 23, 2021
@williamdes
Add a ChangeLog entry for #16252
b24bb6e 
Signed-off-by: William Desportes <williamdes@wdes.fr>
Enhancements automation moved this from Interface to Done Jan 24, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@williamdes williamdes

Labels
enhancement A feature request for improving phpMyAdmin has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete ui Issues relating to the user interface
Projects
Enhancements
  
Done
Milestone
5.1.0
Development

Successfully merging a pull request may close this issue.

Modified CSS value font-size to revert instead of 1em. rajat315315/phpmyadmin
3 participants
@williamdes @rajat315315 @qcybb