Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editing Geometry data throws error on using the GUI #16325

Closed
shucon opened this issue Aug 30, 2020 · 1 comment · Fixed by #16330
Closed

Editing Geometry data throws error on using the GUI #16325

shucon opened this issue Aug 30, 2020 · 1 comment · Fixed by #16330
Assignees
@williamdes
Labels
Bug A problem or regression with an existing feature good first issue has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete help wanted
Projects
issues
Milestone
5.0.3

Comments

@shucon
Copy link
Contributor

shucon commented Aug 30, 2020 •
edited by williamdes

Describe the bug

Editing Geometry data using GUI is not working.

The error is due to the fact that the Query generated is UPDATE `gis_all` SET `shape` = ST_PointFromText(\'POINT(66 54)\',0) WHERE `gis_all`.`name` = 'POINT' but it should be UPDATE `gis_all` SET `shape` = ST_PointFromText('POINT(66 54)',0) WHERE `gis_all`.`name` = 'POINT' which works fine when edited and executed as an SQL command.

It is true for all geometries I tested.

To Reproduce

Steps to reproduce the behavior:

  1. Click on Edit to edit a geometry data
  2. Change the values and click GO
  3. See error

Expected behavior

The value should be edited.

Screenshots

Screenshot from 2020-08-31 00-00-50
Screenshot from 2020-08-31 00-01-04

Server configuration

  • Operating system: Ubuntu 20.04
  • Web server: Apache
  • Database version: libmysql - mysqlnd 7.4.3
  • PHP version: 7.4.3
  • phpMyAdmin version: master

Additional context

Add any other context about the problem here.
@shucon
Copy link
Contributor Author

shucon commented Aug 30, 2020

Good-first-issue @williamdes @ibennetch

@williamdes williamdes added Bug A problem or regression with an existing feature good first issue help wanted labels Sep 2, 2020
petrduda added a commit to petrduda/phpmyadmin that referenced this issue Sep 2, 2020
@petrduda
Fix phpmyadmin#16325 Editing geometry data throws error on using the GUI
9bd89f3 
Signed-off-by: Petr Duda <petrduda@seznam.cz>
@petrduda petrduda mentioned this issue Sep 2, 2020
Merged
6 tasks
@williamdes williamdes added this to Needs triage in issues via automation Sep 7, 2020
@williamdes williamdes moved this from Needs triage to to be fixed soon in issues Sep 7, 2020
@williamdes williamdes self-assigned this Sep 20, 2020
@williamdes williamdes added this to the 5.0.3 milestone Sep 20, 2020
@williamdes williamdes added the has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete label Sep 20, 2020
williamdes pushed a commit to petrduda/phpmyadmin that referenced this issue Sep 20, 2020
@petrduda @williamdes
Fix phpmyadmin#16325 Editing geometry data throws error on using the GUI
6195a23 
Signed-off-by: Petr Duda <petrduda@seznam.cz>
williamdes added a commit that referenced this issue Sep 20, 2020
@williamdes
Merge #16330 - Fix #16325, Fix #15109 - Editing geometry data throws …
4f8e1b8 
…error on using the GUI

Pull-request: #16330
Fixes: #16325
Fixes: #15109

Signed-off-by: William Desportes <williamdes@wdes.fr>
williamdes added a commit that referenced this issue Sep 20, 2020
@williamdes
Add a ChangeLog entry for #15109 and #16325
6c135c5 
Signed-off-by: William Desportes <williamdes@wdes.fr>
issues automation moved this from to be fixed soon to Closed Sep 20, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@williamdes williamdes

Labels
Bug A problem or regression with an existing feature good first issue has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete help wanted
Projects
issues
  
Closed
Milestone
5.0.3
Development

Successfully merging a pull request may close this issue.

Fix #16325 Editing geometry data throws error on using the GUI petrduda/phpmyadmin
2 participants
@williamdes @shucon