Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Textarea resize CSS #16355

Closed
Tobeworks opened this issue Sep 16, 2020 · 5 comments
Closed

Textarea resize CSS #16355

Tobeworks opened this issue Sep 16, 2020 · 5 comments
Assignees
Labels
Bug A problem or regression with an existing feature has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete help wanted ui Issues relating to the user interface
Projects
Milestone

Comments

@Tobeworks
Copy link

Tobeworks commented Sep 16, 2020

Describe the bug

resize: vertical; in main Template pmahomme is not practical

To Reproduce

Any varchar or text field

Steps to reproduce the behavior:

  1. Go to any varchar field
  2. Click on 'edit'

Expected behavior

The textarea should not be resize:vertical, it should be overwritten to resize:both; to edit bigger data amounts
The issue comes from the use of Bootstrap`s reboot, which was implemented in bootstrap@4.0.0
https://getbootstrap.com/docs/4.0/content/reboot/
Issue found in _reboot.scss

  • phpMyAdmin version: 5.0.2
@williamdes
Copy link
Member

What version of phpMyAdmin are you using ?

@williamdes williamdes added this to Needs triage in Questions via automation Sep 16, 2020
@williamdes williamdes moved this from Needs triage to Needs a second check to be a bug in Questions Sep 16, 2020
@Tobeworks
Copy link
Author

Tobeworks commented Sep 16, 2020

What version of phpMyAdmin are you using ?

it`s about the 5.0.2.

Now I downgraded to 4.8.4 (which was the latest on my machine) and it`s working fine. I see there is no use of Bootstrap 4 in the PMA 4.x, so there is no _reboot.scss

@williamdes williamdes removed this from Needs a second check to be a bug in Questions Sep 16, 2020
@williamdes williamdes added this to Needs triage in issues via automation Sep 16, 2020
@williamdes williamdes added Bug A problem or regression with an existing feature help wanted ui Issues relating to the user interface labels Sep 16, 2020
@williamdes
Copy link
Member

What version of phpMyAdmin are you using ?

it`s about the 5.0.2.

Now I downgraded to 4.8.4 (which was the latest on my machine) and it`s working fine. I see there is no use of Bootstrap 4 in the PMA 4.x, so there is no _reboot.scss

Thank you for this precious information
Could you paste before and after screnshots? That would help contributors fix this issue :)

@Tobeworks
Copy link
Author

Could you paste before and after screnshots? That would help contributors fix this issue

demo_phpmyadmin_net_phpMyAdmin_demo_MySQL_testdb_Foobar_Test_phpMyAdmin_5_1_0_dev

@williamdes
Copy link
Member

@williamdes williamdes self-assigned this Sep 19, 2020
@williamdes williamdes added this to the 5.0.3 milestone Sep 19, 2020
@williamdes williamdes added the has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete label Sep 19, 2020
williamdes added a commit that referenced this issue Sep 19, 2020
Signed-off-by: William Desportes <williamdes@wdes.fr>
issues automation moved this from Needs triage to Closed Sep 19, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug A problem or regression with an existing feature has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete help wanted ui Issues relating to the user interface
Projects
issues
  
Closed
Development

No branches or pull requests

2 participants