Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

APC vanished #16382

Closed
williamdes opened this issue Oct 2, 2020 · 3 comments · Fixed by #16866
Closed

APC vanished #16382

williamdes opened this issue Oct 2, 2020 · 3 comments · Fixed by #16866
Assignees
@williamdes
Labels
Bug A problem or regression with an existing feature documentation has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete
Projects
issues
Milestone
5.2.0

Comments

@williamdes
Copy link
Member

See: https://travis-ci.org/github/phpmyadmin/phpmyadmin/jobs/732245185#L496
See: https://pecl.php.net/package/APC

See: https://www.php.net/manual/en/book.apcu.php#125057

APCu is the official replacement for the outdated APC extension. APC provided both opcode caching (opcache) and object caching. As PHP versions 5.5 and above include their own opcache, APC was no longer compatible, and its opcache functionality became useless. The developers of APC then created APCu, which offers only the object caching (read "in memory data caching") functionality (they removed the outdated opcache).

Should we remove APC from 5.0.x series ?
@ibennetch
Copy link
Member

So APC hasn't been usable in PHP since 5.5? In that case, we can definitely remove APC support.

Should we migrate to APCu?

@williamdes williamdes added documentation Bug A problem or regression with an existing feature labels Oct 7, 2020
@williamdes williamdes added this to Needs triage in issues via automation Oct 7, 2020
@williamdes williamdes moved this from Needs triage to to be fixed soon in issues Oct 7, 2020
williamdes added a commit that referenced this issue Oct 11, 2020
@williamdes
#16382 - Remove APC from PHP documentation
0d98829 
Signed-off-by: William Desportes <williamdes@wdes.fr>
@williamdes
Copy link
Member Author

So APC hasn't been usable in PHP since 5.5? In that case, we can definitely remove APC support.

Should we migrate to APCu?

I just tried to migrate but I think there is no way to make it work, the apc.rfc1867 was removed: krakjoe/apcu#349

@williamdes
Copy link
Member Author

Confirmed upstream: krakjoe/apcu#349 (comment)

Working on removing the code

@williamdes williamdes self-assigned this Apr 28, 2021
@williamdes williamdes added the has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete label Apr 28, 2021
@williamdes williamdes added this to the 5.2.0 milestone Apr 28, 2021
@williamdes williamdes mentioned this issue Apr 28, 2021
Merged
issues automation moved this from to be fixed soon to Closed Apr 28, 2021
williamdes added a commit that referenced this issue Apr 28, 2021
@williamdes
Merge #16866 - Fix #16382 - remove apc extension code
fbd9d88 
Pull-request: #16866
Fixes: #16382

Signed-off-by: William Desportes <williamdes@wdes.fr>
williamdes added a commit that referenced this issue Apr 28, 2021
@williamdes
Add a ChangeLog entry for #16382
ea59eb8 
Signed-off-by: William Desportes <williamdes@wdes.fr>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@williamdes williamdes

Labels
Bug A problem or regression with an existing feature documentation has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete
Projects
issues
  
Closed
Milestone
5.2.0
Development

Successfully merging a pull request may close this issue.

Fix #16382 - remove apc extension code williamdes/phpmyadmintest
2 participants
@ibennetch @williamdes