Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

password generation not working after failing to create new user #16404

Closed
zyli-syno opened this issue Oct 13, 2020 · 6 comments
Closed

password generation not working after failing to create new user #16404

zyli-syno opened this issue Oct 13, 2020 · 6 comments
Assignees
Labels
Bug A problem or regression with an existing feature good first issue has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete help wanted question Used when we need feedback from the submitter or when the issue is a question about PMA
Projects
Milestone

Comments

@zyli-syno
Copy link

Describe the bug

The "generate password" button on the /server_privileges.php?adduser=1 encountered js error after failing to create new user.
In js/functions.js, the undefined argument (this.form) was passed to the function displayPasswordGenerateButton().

To Reproduce

Steps to reproduce the behavior:

  1. Enable "strict password validation mode" for MariaDB 10
  2. Go to phpmyadmin, click on "Add user account" on the "User accounts"
  3. Create an user with weak password that does not meet the requirement of "strict password validation mode"
  4. Click on "Go"
  5. The user creation fails due to the "strict password validation mode" requirement
  6. Click on "generate password", the password will not be generated

Expected behavior

The "generate password" should work and allow the user to re-enter a strong password to meet the password strength requirement.

Screenshots

Picture

Server configuration

  • Operating system: Windows 10
  • Web server: nginx
  • Database version: MariaDB 10
  • PHP version: PHP 7.3
  • phpMyAdmin version: 4.9.6

Client configuration

  • Browser: Chrome
  • Operating system: Windows 10
@williamdes williamdes added the Bug A problem or regression with an existing feature label Oct 13, 2020
@williamdes williamdes added this to Needs triage in issues via automation Oct 13, 2020
@williamdes
Copy link
Member

Reproduced on (root, no password)

I used before creating a user:

INSTALL SONAME 'simple_password_check'

@williamdes williamdes added this to the 5.0.4 milestone Oct 13, 2020
@williamdes williamdes moved this from Needs triage to to be fixed soon in issues Oct 13, 2020
@williamdes williamdes removed this from the 5.0.4 milestone Oct 13, 2020
@williamdes
Copy link
Member

Hi, thank you for the report !
The form seems to not exist when the user is not created after a form submit.

@williamdes
Copy link
Member

Hi @wikiccu
Maybe you could try this one ?
#13270 (comment)

@sukrosono
Copy link

it also fails on Debian base
Server configuration
Operating system: mint 20.1
Web server: Apache/2.4.41
Database version: mysql
PHP version: PHP 7.4
phpMyAdmin Version information: 5.0.4deb2~bpo10+1+focal1

Client configuration
Browser: Chromium
Operating system: LinuxMint

@williamdes
Copy link
Member

Could you post a screenshot and more details @brutalcrozt ?

@williamdes williamdes added the question Used when we need feedback from the submitter or when the issue is a question about PMA label Feb 24, 2021
@sukrosono
Copy link

I am sorry, my time is limited.
I move on to create the password manually.

It might be related that the created password from phpmyadmin is too weak, and the MySQL policy demands a stronger one.
It also on my machine is not reproducible because I am done a lot of upgrade instead of a fresh install.

shucon added a commit to shucon/phpmyadmin that referenced this issue Apr 12, 2021
…failure

Signed-off-by: Saksham Gupta <shucon01@gmail.com>
@williamdes williamdes added the has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete label Apr 13, 2021
shucon added a commit to shucon/phpmyadmin that referenced this issue Apr 13, 2021
…failure

Signed-off-by: Saksham Gupta <shucon01@gmail.com>

Check error on SQL query

Signed-off-by: Saksham Gupta <shucon01@gmail.com>
shucon added a commit to shucon/phpmyadmin that referenced this issue Apr 15, 2021
…failure

Signed-off-by: Saksham Gupta <shucon01@gmail.com>

Check error on SQL query

Signed-off-by: Saksham Gupta <shucon01@gmail.com>

Lint fix

Signed-off-by: Saksham Gupta <shucon01@gmail.com>
@williamdes williamdes self-assigned this Apr 19, 2021
@williamdes williamdes added this to the 5.1.1 milestone Apr 19, 2021
williamdes added a commit that referenced this issue Apr 19, 2021
…eation failure

Signed-off-by: William Desportes <williamdes@wdes.fr>
williamdes added a commit that referenced this issue Apr 19, 2021
Signed-off-by: William Desportes <williamdes@wdes.fr>
issues automation moved this from to be fixed soon to Closed Apr 19, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug A problem or regression with an existing feature good first issue has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete help wanted question Used when we need feedback from the submitter or when the issue is a question about PMA
Projects
issues
  
Closed
Development

No branches or pull requests

3 participants