Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Single clicking on row starts editing even if GridEditing is set to double-click #16420

Closed
Draghmar opened this issue Oct 20, 2020 · 5 comments · Fixed by #16426
Closed

Single clicking on row starts editing even if GridEditing is set to double-click #16420

Draghmar opened this issue Oct 20, 2020 · 5 comments · Fixed by #16426
Assignees
@williamdes
Labels
Bug A problem or regression with an existing feature has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete
Projects
issues
Milestone
5.1.1

Comments

@Draghmar
Copy link

Describe the bug

Even though I have set GridEditing to double-click, single clicking on any row will start edit it. This started to happen after updating to 5.0.3, previously it worked as indented. I checked both config.inc.php and settings in Settings->Main Panel->Browsing mode and there is double-click selected. There are no JS errors in browser's console.

To Reproduce

Steps to reproduce the behaviour:

  1. Go to any table.
  2. Click on any row.

Expected behaviour

I should be able to select text or row (with ctrl).

Server configuration

  • Operating system: Arch Linux
  • Web server: Apache/2.4.46
  • Database version: 10.5.6
  • PHP version: 7.4.11
  • phpMyAdmin version: 5.0.3

Client configuration

  • Browser: FireFox 82.0
  • Operating system: Windows 10 (v2004)
@williamdes williamdes added the Bug A problem or regression with an existing feature label Oct 20, 2020
@williamdes
Copy link
Member

Hi @Draghmar
Thank you for reporting this issue !
And very cool avatar ;)

@williamdes williamdes added this to Needs triage in issues via automation Oct 20, 2020
@williamdes williamdes moved this from Needs triage to to be fixed soon in issues Oct 20, 2020
@rajat315315 rajat315315 mentioned this issue Oct 22, 2020
Merged
6 tasks
@rajat315315
Copy link
Contributor

Fixed.

@williamdes williamdes added the has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete label Oct 22, 2020
@Draghmar
Copy link
Author

Thanks @williamdes :)
And thanks all for fast response! Looking at PR I removed that piece of code from my installation and it indeed do the trick! :)

@williamdes williamdes added this to the 5.1.0 milestone Oct 23, 2020
@ibennetch ibennetch modified the milestones: 5.1.0, 5.1.1 Feb 24, 2021
@williamdes williamdes self-assigned this Apr 25, 2021
williamdes added a commit that referenced this issue Apr 25, 2021
@williamdes
Add a ChangeLog entry for #16420
6e8c65c 
Signed-off-by: William Desportes <williamdes@wdes.fr>
@williamdes
Copy link
Member

Will be fixed in 5.1.1
For now it reverts #14411 and I hope to get it back fixed before the release, anyway I was the reporter so it is not a big deal

issues automation moved this from to be fixed soon to Closed Apr 25, 2021
@Draghmar
Copy link
Author

Draghmar commented Jun 9, 2021

Just to add info about the state of this issue after updating to 5.1.1 - I can confirm it's fixed! Thanks a lot! :D

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@williamdes williamdes

Labels
Bug A problem or regression with an existing feature has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete
Projects
issues
  
Closed
Milestone
5.1.1
4 participants
@Draghmar @ibennetch @williamdes @rajat315315