Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error 'Please enter a valid number' when searching through a list of numerical values #16424

Closed
velkro opened this issue Oct 21, 2020 · 9 comments · Fixed by #16666
Closed

Error 'Please enter a valid number' when searching through a list of numerical values #16424

velkro opened this issue Oct 21, 2020 · 9 comments · Fixed by #16666
Assignees
@williamdes
Labels
Bug A problem or regression with an existing feature ui Issues relating to the user interface
Projects
issues
Milestone
5.1.0

Comments

@velkro
Copy link

velkro commented Oct 21, 2020

Describe the bug

It is not possible to search for a numeric value in a comma-delimited list.

To Reproduce

Steps to reproduce the behavior:

Search in a column of type INT
Operator IN(...)
Values 4379,24541,7772
Error : Please enter a valid number

Expected behavior

in the previous versions, PMA selected the values present in the list

Screenshots

PMA-in

Server configuration

  • Operating system: Mac OS Catalina
  • Web server: Apache 2
  • Database version: 8.0.18 - MySQL Community Server -
  • PHP version: 7.3.11
  • phpMyAdmin version: 5.0.4

Client configuration

  • Browser: Firefox
  • Operating system: Mac OS

Additional context
@williamdes williamdes added this to Needs triage in issues via automation Oct 21, 2020
@williamdes
Copy link
Member

This is quite strange because it was fixed in 5.0.3 🤔

@ibennetch
Copy link
Member

ibennetch commented Oct 21, 2020 •
edited

What's even more strange is that I can reproduce this in current QA_5_0 and with the 5.0.3 release...even though 66338cc was in RELEASE_5_0_3.

The other duplicate issue was #16041.

@williamdes
Copy link
Member

What's even more strange is that I can reproduce this in current QA_5_0 and with the 5.0.3 release.

Will we have another 5.0 release?

@ibennetch
Copy link
Member

Will we have another 5.0 release?

No, we'll move forward with 5.1 and close QA_5_0 in two weeks.

@williamdes
Copy link
Member

williamdes commented Oct 21, 2020 •
edited

Will we have another 5.0 release?

No, we'll move forward with 5.1 and close QA_5_0 in two weeks.

Okay, then I will merge nothing more into QA_5_0.
Thank you for quick response.

Was a fix for the same issue reported: #16077

@velkro
Copy link
Author

velkro commented Oct 22, 2020

Thanks, I'm back to 5.0.3: it works :)

@williamdes williamdes added Bug A problem or regression with an existing feature question Used when we need feedback from the submitter or when the issue is a question about PMA labels Oct 22, 2020
@williamdes williamdes added this to the 5.1.0 milestone Nov 3, 2020
@williamdes williamdes moved this from Needs triage to High priority in issues Feb 9, 2021
@MauricioFauth
Copy link
Member

I was not able to reproduce this with 5.0.3+.

@williamdes
Copy link
Member

This only can be reproduced if the user does change the field type after adding a value for example 1,2,3,45 and then choosing IN(...)

@williamdes williamdes removed the question Used when we need feedback from the submitter or when the issue is a question about PMA label Feb 17, 2021
@williamdes williamdes self-assigned this Feb 17, 2021
@williamdes williamdes added the ui Issues relating to the user interface label Feb 17, 2021
@williamdes
Copy link
Member

Affects also QA_5_0 (for the record)

@williamdes williamdes moved this from High priority to Medium priority in issues Feb 17, 2021
shucon added a commit to shucon/phpmyadmin that referenced this issue Feb 18, 2021
@shucon
Fix phpmyadmin#16424 - Numerical search in table and zoom
dda3684 
Signed-off-by: Saksham Gupta <shucon01@gmail.com>
@shucon shucon mentioned this issue Feb 18, 2021
Merged
6 tasks
shucon added a commit to shucon/phpmyadmin that referenced this issue Feb 18, 2021
@shucon
Fix phpmyadmin#16424 - Numerical search in table and zoom
7843610 
Signed-off-by: Saksham Gupta <shucon01@gmail.com>

Fixes phpmyadmin#16667

Signed-off-by: Saksham Gupta <shucon01@gmail.com>
williamdes added a commit that referenced this issue Feb 18, 2021
@williamdes
Merge #16666 - Fix #16424 - Numerical search in table and zoom
4df8cd0 
Pull-request: #16666
Fixes: #16424

Signed-off-by: William Desportes <williamdes@wdes.fr>
williamdes added a commit that referenced this issue Feb 18, 2021
@williamdes
Add a ChangeLog entry for #16669, #16424 and #16667
25083c1 
Signed-off-by: William Desportes <williamdes@wdes.fr>
williamdes added a commit that referenced this issue Feb 18, 2021
@williamdes
Ref #16666 - Ref #16424 - Adjust the index like the zoom controller
6be33c4 
Even if this is not needed, better that it is the same in the 2 controllers

Signed-off-by: William Desportes <williamdes@wdes.fr>
issues automation moved this from Medium priority to Closed Feb 19, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@williamdes williamdes

Labels
Bug A problem or regression with an existing feature ui Issues relating to the user interface
Projects
issues
  
Closed
Milestone
5.1.0
Development

Successfully merging a pull request may close this issue.

Fix #16424 - Numerical search in table and zoom shucon/phpmyadmin
4 participants
@MauricioFauth @ibennetch @velkro @williamdes