Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete from $table #16425

Closed
OlafvdSpek opened this issue Oct 22, 2020 · 3 comments · Fixed by #16750
Closed

Delete from $table #16425

OlafvdSpek opened this issue Oct 22, 2020 · 3 comments · Fixed by #16750
Assignees
@williamdes
Labels
enhancement A feature request for improving phpMyAdmin has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete ui Issues relating to the user interface
Projects
Enhancements
Milestone
5.2.0

Comments

@OlafvdSpek
Copy link

Table operations tab has a truncate $table operation but not a delete from $table operation. Could it be added?
Truncate doesn't work on tables with foreign keys.
@williamdes williamdes added the enhancement A feature request for improving phpMyAdmin label Oct 22, 2020
@williamdes williamdes added this to Triage zone in Enhancements via automation Oct 22, 2020
@williamdes williamdes moved this from Triage zone to Interface in Enhancements Oct 22, 2020
@OlafvdSpek
Copy link
Author

OlafvdSpek commented Oct 22, 2020 •
edited

It'd also be nice to rename Delete the table (DROP) to Drop the table.

@lem9
Copy link
Contributor

lem9 commented Nov 17, 2020

About "Delete the table", I don't want to start an argument, but not every phpMyAdmin's users know about SQL. This was the reason of the "Delete the table (DROP)" which is clearer for everyone, IMO.

@williamdes
Copy link
Member

williamdes commented Nov 17, 2020 •
edited

About "Delete the table", I don't want to start an argument, but not every phpMyAdmin's users know about SQL. This was the reason of the "Delete the table (DROP)" which is clearer for everyone, IMO.

Thank you @lem9
There will be no renaming then.

shucon added a commit to shucon/phpmyadmin that referenced this issue Mar 21, 2021
@shucon
Enhancement phpmyadmin#16425 : DELETE FROM table
b9b675d 
Signed-off-by: Saksham Gupta <shucon01@gmail.com>
@shucon shucon mentioned this issue Mar 21, 2021
Merged
6 tasks
@williamdes williamdes added has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete ui Issues relating to the user interface labels Mar 21, 2021
williamdes added a commit to shucon/phpmyadmin that referenced this issue Apr 23, 2021
@shucon @williamdes
Fix phpmyadmin#16425 - Add DELETE FROM table
360cf38 
Signed-off-by: Saksham Gupta <shucon01@gmail.com>
Co-authored-by: William Desportes <williamdes@wdes.fr>
@williamdes williamdes self-assigned this Apr 23, 2021
@williamdes williamdes added this to the 5.2.0 milestone Apr 23, 2021
williamdes added a commit to shucon/phpmyadmin that referenced this issue Jul 20, 2021
@shucon @williamdes
phpmyadmin#16425 - Add DELETE FROM table
aa85264 
Co-authored-by: William Desportes <williamdes@wdes.fr>
Signed-off-by: Saksham Gupta <shucon01@gmail.com>
williamdes added a commit to shucon/phpmyadmin that referenced this issue Jul 20, 2021
@williamdes
Code improvements for phpmyadmin#16425
a7a44a5 
Signed-off-by: William Desportes <williamdes@wdes.fr>
williamdes added a commit that referenced this issue Jul 20, 2021
@williamdes
Add a ChangeLog entry for #16425
b21acd2 
Signed-off-by: William Desportes <williamdes@wdes.fr>
Enhancements automation moved this from Interface to Done Jul 20, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@williamdes williamdes

Labels
enhancement A feature request for improving phpMyAdmin has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete ui Issues relating to the user interface
Projects
Enhancements
  
Done
Milestone
5.2.0
Development

Successfully merging a pull request may close this issue.

Fix #16425 - Add DELETE FROM table shucon/phpmyadmin
3 participants
@lem9 @OlafvdSpek @williamdes