PHP 8 compatibility

[ibennetch]

When using PHP 8.0.0rc1 provided by the Sury repository, I get the following message when running composer update:

    - php-webdriver/webdriver 1.8.3 requires php ^5.6 || ~7.0 -> your PHP version (8.0.0rc1) does not satisfy that requirement.
    - php-webdriver/webdriver 1.8.2 requires php ^5.6 || ~7.0 -> your PHP version (8.0.0rc1) does not satisfy that requirement.
    - php-webdriver/webdriver 1.8.1 requires php ^5.6 || ~7.0 -> your PHP version (8.0.0rc1) does not satisfy that requirement.
    - php-webdriver/webdriver 1.8.0 requires php ^5.6 || ~7.0 -> your PHP version (8.0.0rc1) does not satisfy that requirement.
    - php-webdriver/webdriver 1.8.3 requires php ^5.6 || ~7.0 -> your PHP version (8.0.0rc1) does not satisfy that requirement.
    - Installation request for php-webdriver/webdriver ^1.8 -> satisfiable by php-webdriver/webdriver[1.8.0, 1.8.1, 1.8.2, 1.8.3].

[ibennetch]

Looks like some of our developers are already trying to get this resolved :) php-webdriver/php-webdriver#826

[williamdes]

I renamed this issue to have a central point to track php 8 compatibility issues.

[williamdes]

Here is one for tcpdf: tecnickcom/TCPDF#222

[ibennetch]

Maybe we should make a new project for PHP 8 compatibility problems?

[williamdes]

Maybe we should make a new project for PHP 8 compatibility problems?

One column on the issues board seems a better idea, else the project will be forgotten and empty ;)
Good suggestion

[williamdes]

Here it is: https://github.com/phpmyadmin/phpmyadmin/projects/7#column-11361204

This issue related to #16268

[williamdes]

• Fix [PHP 8.0] Function libxml_disable_entity_loader() is deprecated #16490
• Fix testsuite
• Release sql-parser

1) PhpMyAdmin\Tests\Engines\PbxtTest::testResolveTypeSize with data set #2 ('A4', array('0', 'B'))
TypeError: Unsupported operand types: string / int

libraries/classes/Util.php:528
libraries/classes/Engines/Pbxt.php:156
test/classes/Engines/PbxtTest.php:175
vendor/phpunit/phpunit/phpunit:61

2) PhpMyAdmin\Tests\HeaderTest::testEnable
Undefined array key "Servers"

libraries/classes/Navigation/Navigation.php:96
libraries/classes/Header.php:433
test/classes/HeaderTest.php:65
vendor/phpunit/phpunit/phpunit:61

3) PhpMyAdmin\Tests\HeaderTest::testSetBodyId
Undefined array key "Servers"

libraries/classes/Navigation/Navigation.php:96
libraries/classes/Header.php:433
test/classes/HeaderTest.php:78
vendor/phpunit/phpunit/phpunit:61

--

There were 2 failures:

1) PhpMyAdmin\Tests\Gis\GisMultiPointTest::testPrepareRowAsSvg with data set #0 ('MULTIPOINT(12 35,48 75,69 23,...35 78)', 'svg', '#B02EE0', array(12, 69, 2, 150), '/^(<circle cx="72" cy="138" r...\/>)$/')
Failed asserting that 0 matches expected 1.

test/classes/Gis/GisMultiPointTest.php:302
vendor/phpunit/phpunit/phpunit:61

2) PhpMyAdmin\Tests\Gis\GisPointTest::testPrepareRowAsSvg with data set #0 ('POINT(12 35)', 'svg', '#B02EE0', array(12, 69, 2, 150), '')
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-''
+'<circle cx="0" cy="218" r="3" name="svg" id="svg1737950962" class="point vector" fill="white" stroke="#B02EE0" stroke-width="2"/>'

test/classes/Gis/GisPointTest.php:314
vendor/phpunit/phpunit/phpunit:61

--

[JohnRDOrazio]

now that PHP 8 compatibility has been fixed in php-webdriver 1.9.0 and 1.10.0, can the requirement in composer.json please be bumped now to "php-webdriver/webdriver": "^1.10",. I had to do this manually in order for composer update to succeed with PHP 8.

[williamdes]

now that PHP 8 compatibility has been fixed in php-webdriver 1.9.0 and 1.10.0, can the requirement in composer.json please be bumped now to "php-webdriver/webdriver": "^1.10",. I had to do this manually in order for composer update --no-dev to succeed with PHP 8.

I do not see where this does make sense, what branch are you using ?
Are you up to date ?

[JohnRDOrazio]

I am using the master branch. The composer.json on master has a "caret version range" on webdriver:

phpmyadmin/composer.json

Line 83 in 87526f2

"php-webdriver/webdriver": "^1.8",

Running a composer update under PHP 8 I was getting the errors indicated in this issue:

When using PHP 8.0.0rc1 provided by the Sury repository, I get the following message when running composer update:

    - php-webdriver/webdriver 1.8.3 requires php ^5.6 || ~7.0 -> your PHP version (8.0.0rc1) does not satisfy that requirement.
    - php-webdriver/webdriver 1.8.2 requires php ^5.6 || ~7.0 -> your PHP version (8.0.0rc1) does not satisfy that requirement.
    - php-webdriver/webdriver 1.8.1 requires php ^5.6 || ~7.0 -> your PHP version (8.0.0rc1) does not satisfy that requirement.
    - php-webdriver/webdriver 1.8.0 requires php ^5.6 || ~7.0 -> your PHP version (8.0.0rc1) does not satisfy that requirement.
    - php-webdriver/webdriver 1.8.3 requires php ^5.6 || ~7.0 -> your PHP version (8.0.0rc1) does not satisfy that requirement.
    - Installation request for php-webdriver/webdriver ^1.8 -> satisfiable by php-webdriver/webdriver[1.8.0, 1.8.1, 1.8.2, 1.8.3].

And I see that there has been a fix in webdriver in the meantime: #16429 (comment)

Looks like some of our developers are already trying to get this resolved :) php-webdriver/php-webdriver#826

The fix in webdriver is announced here: php-webdriver/php-webdriver#828 (comment)

I manually bumped the version of webdriver in composer.json to "php-webdriver/webdriver": "^1.10".

I was then able to run composer update successfully without errors.

[williamdes]

I pushed a commit for that: 8529c01

But for me it makes no sense at all, maybe you can let me know why you need this ?
Since composer update is the command everyone runs (in dev mode) 🤔

[JohnRDOrazio]

I pushed a commit for that: 8529c01

But for me it makes no sense at all, maybe you can let me know why you need this ?
Since composer update is the command everyone runs (in dev mode) 🤔

I'm not sure I understand. Are you saying nobody else has errors, when issuing composer update under PHP 8, with a composer.json requirement for 'webdriver: ^1.8'?
Or maybe I understand, that this wouldn't be necessary to simply install with a composer update --no-dev, as the webdriver won't be installed anyway with --no-dev. Well, I'm not not going to make a big deal out of this issue because I don't actually do development (so far anyways) on the PhpMyAdmin repository, but it will prevent errors for anyone running a simple composer update, so I wouldn't be too picky about bumping the version because it can only help. If there's no harm done, there's only benefits to avoiding errors in any case...

[williamdes]

I'm not sure I understand. Are you saying nobody else has errors, when issuing composer update under PHP 8, with a composer.json requirement for 'webdriver: ^1.8'?

Exactly, because it updates to the latest version. Nobody else had this error while updating 🤔

composer update --no-dev

Sure, this is the right command to run in production. Devs can just use composer update

so I wouldn't be too picky about bumping the version because it can only help. If there's no harm done, there's only benefits to avoiding errors in any case...

Sure, this will help because if someone used the prefer lowest option of composer I think the error would then be accurate