PHP 8 compatibility

[ibennetch]

When using PHP 8.0.0rc1 provided by the Sury repository, I get the following message when running composer update:

    - php-webdriver/webdriver 1.8.3 requires php ^5.6 || ~7.0 -> your PHP version (8.0.0rc1) does not satisfy that requirement.
    - php-webdriver/webdriver 1.8.2 requires php ^5.6 || ~7.0 -> your PHP version (8.0.0rc1) does not satisfy that requirement.
    - php-webdriver/webdriver 1.8.1 requires php ^5.6 || ~7.0 -> your PHP version (8.0.0rc1) does not satisfy that requirement.
    - php-webdriver/webdriver 1.8.0 requires php ^5.6 || ~7.0 -> your PHP version (8.0.0rc1) does not satisfy that requirement.
    - php-webdriver/webdriver 1.8.3 requires php ^5.6 || ~7.0 -> your PHP version (8.0.0rc1) does not satisfy that requirement.
    - Installation request for php-webdriver/webdriver ^1.8 -> satisfiable by php-webdriver/webdriver[1.8.0, 1.8.1, 1.8.2, 1.8.3].

[ibennetch]

Looks like some of our developers are already trying to get this resolved :) php-webdriver/php-webdriver#826

[williamdes]

I renamed this issue to have a central point to track php 8 compatibility issues.

[williamdes]

Here is one for tcpdf: tecnickcom/TCPDF#222

[ibennetch]

Maybe we should make a new project for PHP 8 compatibility problems?

[williamdes]

Maybe we should make a new project for PHP 8 compatibility problems?

One column on the issues board seems a better idea, else the project will be forgotten and empty ;)
Good suggestion

[williamdes]

Here it is: https://github.com/phpmyadmin/phpmyadmin/projects/7#column-11361204

This issue related to #16268

[williamdes]

• Fix [PHP 8.0] Function libxml_disable_entity_loader() is deprecated #16490
• Fix testsuite
• Release sql-parser

1) PhpMyAdmin\Tests\Engines\PbxtTest::testResolveTypeSize with data set #2 ('A4', array('0', 'B'))
TypeError: Unsupported operand types: string / int

libraries/classes/Util.php:528
libraries/classes/Engines/Pbxt.php:156
test/classes/Engines/PbxtTest.php:175
vendor/phpunit/phpunit/phpunit:61

2) PhpMyAdmin\Tests\HeaderTest::testEnable
Undefined array key "Servers"

libraries/classes/Navigation/Navigation.php:96
libraries/classes/Header.php:433
test/classes/HeaderTest.php:65
vendor/phpunit/phpunit/phpunit:61

3) PhpMyAdmin\Tests\HeaderTest::testSetBodyId
Undefined array key "Servers"

libraries/classes/Navigation/Navigation.php:96
libraries/classes/Header.php:433
test/classes/HeaderTest.php:78
vendor/phpunit/phpunit/phpunit:61

--

There were 2 failures:

1) PhpMyAdmin\Tests\Gis\GisMultiPointTest::testPrepareRowAsSvg with data set #0 ('MULTIPOINT(12 35,48 75,69 23,...35 78)', 'svg', '#B02EE0', array(12, 69, 2, 150), '/^(<circle cx="72" cy="138" r...\/>)$/')
Failed asserting that 0 matches expected 1.

test/classes/Gis/GisMultiPointTest.php:302
vendor/phpunit/phpunit/phpunit:61

2) PhpMyAdmin\Tests\Gis\GisPointTest::testPrepareRowAsSvg with data set #0 ('POINT(12 35)', 'svg', '#B02EE0', array(12, 69, 2, 150), '')
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-''
+'<circle cx="0" cy="218" r="3" name="svg" id="svg1737950962" class="point vector" fill="white" stroke="#B02EE0" stroke-width="2"/>'

test/classes/Gis/GisPointTest.php:314
vendor/phpunit/phpunit/phpunit:61

--