Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows error message uses trailing / instead of \ #16430

Closed
ibennetch opened this issue Oct 22, 2020 · 2 comments · Fixed by #16436 or #16447
Closed

Windows error message uses trailing / instead of \ #16430

ibennetch opened this issue Oct 22, 2020 · 2 comments · Fixed by #16436 or #16447
Assignees
@williamdes
Labels
enhancement A feature request for improving phpMyAdmin good first issue has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete
Projects
issues
Milestone
5.1.0

Comments

@ibennetch
Copy link
Member

ibennetch commented Oct 22, 2020 •
edited

On Windows, I feel the warning/error message:

The $cfg['TempDir'] (C:\inetpub\phpMyAdmin\tmp/) is not accessible

should use a backslash \ instead of a frontslash /as the final character.

This is quite minor but looks wrong. It's possible there are other places in the code that act in a similar way.
@williamdes williamdes added this to the 5.1.0 milestone Oct 22, 2020
@williamdes williamdes added this to Needs triage in issues via automation Oct 22, 2020
@williamdes williamdes moved this from Needs triage to Medium priority in issues Oct 22, 2020
@MauricioFauth
Copy link
Member

I think this is only aesthetic, since I believe Windows will convert it to the \ character automatically. But, to fix this, we will need to replace the / characters with the DIRECTORY_SEPARATOR constant.

@ibennetch
Copy link
Member Author

ibennetch commented Oct 23, 2020 via email

@williamdes williamdes moved this from Medium priority to Low priority in issues Oct 23, 2020
@williamdes williamdes added enhancement A feature request for improving phpMyAdmin good first issue labels Oct 23, 2020
@MauricioFauth MauricioFauth removed this from the 5.1.0 milestone Oct 23, 2020
@LeeWeiZhang LeeWeiZhang mentioned this issue Oct 26, 2020
Merged
6 tasks
@williamdes williamdes self-assigned this Oct 27, 2020
@williamdes williamdes added this to the 5.1.0 milestone Oct 27, 2020
@williamdes williamdes added the has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete label Oct 27, 2020
@nhalink nhalink mentioned this issue Nov 1, 2020
Merged
6 tasks
williamdes added a commit that referenced this issue Nov 1, 2020
@williamdes
Add a ChangeLog entry for #16430
0f4972c 
Signed-off-by: William Desportes <williamdes@wdes.fr>
issues automation moved this from Low priority to Closed Nov 1, 2020
williamdes added a commit that referenced this issue Nov 1, 2020
@williamdes
Fix a "typo" and a coding standard issue on merge of #16430
8ede871 
Signed-off-by: William Desportes <williamdes@wdes.fr>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@williamdes williamdes

Labels
enhancement A feature request for improving phpMyAdmin good first issue has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete
Projects
issues
  
Closed
Milestone
5.1.0
3 participants
@MauricioFauth @ibennetch @williamdes