Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Header row covers first two rows of table in iOS 14.1 and iPadOS 14.1 #16437

Closed
paulcrawford opened this issue Oct 26, 2020 · 11 comments · Fixed by #16877
Closed

Header row covers first two rows of table in iOS 14.1 and iPadOS 14.1 #16437

paulcrawford opened this issue Oct 26, 2020 · 11 comments · Fixed by #16877
Assignees
Labels
Bug A problem or regression with an existing feature good first issue has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete help wanted
Projects
Milestone

Comments

@paulcrawford
Copy link

Describe the bug

When a table is rendered in Safari on either iOS 14.1 or iPadOS 14.1 the header row with the column descriptors covers the first two rows of the table using the latest version of phpMyAdmin, 5.04. This does not occur with MacOS 10.15.7. Nor does it occur if phpMyAdmin is reverted to version 5.0.2.

To Reproduce

Steps to reproduce the behavior:

  1. Go to any database.
  2. Click on any table
  3. Look at header row and try to read the first two rows of the table.

Expected behavior

The first two rows of the table should be visible, not hidden by the header row

Screenshots

If applicable, add screenshots to help explain your problem.

Server configuration

  • Operating system:Ubuntu 20.0.4
  • Web server:nginx 1.18.0
  • Database version: MariaDB 10.3.22
  • PHP version: 7.4.3
  • phpMyAdmin version: 5.04

Client configuration

  • Browser: Safari
  • Operating system: iOS and iPadOS 14.1

Additional context

Add any other context about the problem here.

@williamdes williamdes added Bug A problem or regression with an existing feature good first issue help wanted labels Oct 27, 2020
@williamdes williamdes added this to the 5.1.0 milestone Oct 27, 2020
@williamdes williamdes added this to Needs triage in issues via automation Oct 27, 2020
@williamdes williamdes moved this from Needs triage to to be fixed soon in issues Oct 27, 2020
@williamdes
Copy link
Member

Seems to be related to #16277

cc @rajat315315

@rajat315315
Copy link
Contributor

@paulcrawford A screenhot would have helped to replicate...

@paulcrawford
Copy link
Author

paulcrawford commented Oct 27, 2020 via email

@paulcrawford
Copy link
Author

Sorry it seems that the screen shots did not come through on my email. So here they are again on GitHub

Here they are:

From MacOS (the correct display)

two rows missing

From iOS (both rows from 2020-10-26 blocked from view by the header row, note the additional whitespace between “+ Options” and the header row)

image

Thanks,

Paul

@arcanisgk
Copy link

arcanisgk commented Oct 29, 2020

the same problem in all browser OS:

windows 10 Google Chrome

image

duplicated as:

#16339

and

#16086

In phpmyadmin 5.0.2 the layout problem still persists from old version, i suggest go to 5.0.4 Version

@paulcrawford
Copy link
Author

@arcanisgk,

The problem I am describing is not the same as the one you show above which also has the duplicates as noted. The one you show is a horizontal shifting of the header row when scrolling. I have seen this as well but basically accepted it as I can tell by the values in the table which column it is. This may well be corrected in 5.0.4 but, if so, it also introduced a vertical shifting of the header. Most of my tables are all in descending order as the values are timestamped with the most recent on top. This makes it critical to be able to see the top two rows, which cannot be seen with 5.0.4. I trust this can be corrected by 5.1.0 or else I will have to stay with 5.0.2. Interestingly, however, is the fact that "all browser OS" do seem to suffer the horizontal shift of the header but the vertical shift seems to affect only iOS and iPadOS but not Safari on MacOS nor Edge on Windows 10 nor Firefox on Ubuntu 18.0.4.5.

@williamdes williamdes moved this from to be fixed soon to High priority in issues Nov 1, 2020
@JBES
Copy link

JBES commented Dec 10, 2020

Untitled-1

This is possibly a variation, PHPMyAdmin 5.0.4, with the immediate cause being the .sticky class in _common.scss line 2982:

.sticky {
  position: -webkit-sticky;
  position: sticky;
  top: 60px;
}

@marto55555
Copy link

marto55555 commented Jan 6, 2021

I think I figured out the root cause of this problem: position: sticky stops working when it's a child of an element with an overflow different from visible, and this is currently by design.

To reproduce the issue with phpMyAdmin, resize the browser window to be <=768px wide. There's a media query in _common.scss line 4190: .responsivetable { overflow-x: auto; }. This breaks the position: sticky and creates that header row offset which hides some of the table content.

I have found 2 ways to work around this:

  1. Remove the overflow-x: auto altogether.
    Pros: the header actually sticks and scrolls horizontally without obstructing the table rows.
    Cons: The whole page scrolls horizontally, forcing the user to scroll to the left in order to see other elements like "Query results operations".
  2. Use that media query to also remove the position: sticky and top: 60px for small-width devices.
    Pros: The first few table rows are not obstructed by the header, and other page elements like "Query results operations" are always visible.
    Cons: the header no longer sticks when scrolling down.

@williamdes
Copy link
Member

Thanks for the feedback @marto55555
Any thoughts @MauricioFauth ?

@williamdes
Copy link
Member

If help, i tried the chrome inspector so see code, and i changed in ".table thead th" position : absolute to position : static, and works for me, the "order" arrow should be static also, i think.

From: #16670 (comment)

@williamdes
Copy link
Member

Hi @marto55555
What about just changing top to top: auto;, I do not see any negative effects

@MauricioFauth MauricioFauth added the has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete label May 4, 2021
@MauricioFauth MauricioFauth self-assigned this May 4, 2021
issues automation moved this from High priority to Closed May 4, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug A problem or regression with an existing feature good first issue has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete help wanted
Projects
issues
  
Closed
Development

Successfully merging a pull request may close this issue.

8 participants