"REFERENCES" priviledge is used by MySQL - wrong message

[mvorisek]

Steps to reproduce

Steps to reproduce the behavior:

1. Go to Edit privileges page of any user
2. Hover mouse over REFERENCES priviledge
3. See wrong message - at least MySQL 8 supports REFERENCES priviledge (without this permission, foreign keys can not be created, thus very misleading)

Expected behavior

Message is shown only for databases that really does NOT support REFERENCES priviledge.

Screenshots

[mvorisek]

it seems that message is hardcoded for any version:

phpmyadmin/templates/server/privileges/privileges_table.twig

Line 78 in f2b2c51

<code><dfn title="{% trans 'Has no effect in this MySQL version.' %}">REFERENCES</dfn></code>

[ibennetch]

From what I can tell, we have to account for three scenarios. MySQL 5.6.22 and newer use this, older versions do not, and all of MariaDB ignores it.

So we should test whether the server is MySQL or MariaDB, check the MySQL version and change the text to "Required for creating foreign key relations", "Not used for this server version", or "Not used for MariaDB servers" as is appropriate.

[prashanttholia]

Hi @williamdes,

I have raised a PR (#16588) carrying a fix for the issue. I request you to review it and accept it if the updates look good.

Thanks.

[mvorisek]

@prashanttholia LGTM, thanks for your contribution!

[prashanttholia]

Thanks! Welcome!