Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selector for table-specific privileges should allow "select all" #16482

Closed
ibennetch opened this issue Nov 15, 2020 · 5 comments · Fixed by #16889
Closed

Selector for table-specific privileges should allow "select all" #16482

ibennetch opened this issue Nov 15, 2020 · 5 comments · Fixed by #16889
Assignees
Labels
enhancement A feature request for improving phpMyAdmin good first issue has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete ui Issues relating to the user interface
Milestone

Comments

@ibennetch
Copy link
Member

When editing a user and picking table-specific privileges, each column is shown in a selector for "Select," "Insert," "Update," and "Reference" privileges.

If I click on one of these, then use my keyboard shortcut for my operating system to select all (command-a on Mac or ctrl-a on Windows) I would like all columns to be selected.

Instead, all of the text on the page is selected.

Perhaps it would be good to have a "select all" clickable link, too?

image

@williamdes williamdes added enhancement A feature request for improving phpMyAdmin good first issue ui Issues relating to the user interface labels Nov 15, 2020
@williamdes williamdes added this to Triage zone in Enhancements via automation Nov 15, 2020
@williamdes williamdes moved this from Triage zone to Interface in Enhancements Nov 15, 2020
@shucon
Copy link
Contributor

shucon commented Mar 31, 2021

I'll start to work on this. I want to know what the purpose of these None checkboxes is?

@williamdes
Copy link
Member

I'll start to work on this. I want to know what the purpose of these None checkboxes is?

Not allowing the column to be {operation}

I think the check all should not tick the None boxes

@shucon
Copy link
Contributor

shucon commented Mar 31, 2021

Which one looks better?
Screenshot from 2021-04-01 01-12-17
Screenshot from 2021-03-31 23-07-39
Thoughts @ibennetch @MauricioFauth @williamdes

I personally think the buttons looks better as there are already a lot of checkboxes.

@williamdes
Copy link
Member

I would say checkboxes to be coherent with our existing interfaces that all use checkboxes to select all values

@shucon
Copy link
Contributor

shucon commented May 7, 2021

Okay. Going with checkboxes.

@williamdes williamdes added the has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete label May 9, 2021
@williamdes williamdes self-assigned this Jul 29, 2021
@williamdes williamdes added this to the 5.2.0 milestone Jul 29, 2021
williamdes added a commit that referenced this issue Jul 29, 2021
…privileges

Pull-request: #16889
Fixes: #16482

Signed-off-by: William Desportes <williamdes@wdes.fr>
williamdes added a commit that referenced this issue Jul 29, 2021
Signed-off-by: William Desportes <williamdes@wdes.fr>
Enhancements automation moved this from Interface to Done Jul 29, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement A feature request for improving phpMyAdmin good first issue has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete ui Issues relating to the user interface
Projects
Enhancements
  
Done
Development

Successfully merging a pull request may close this issue.

3 participants