Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Visual query builder missing "Build Query" button #16485

Closed
ibennetch opened this issue Nov 16, 2020 · 0 comments · Fixed by #16551
Closed

Visual query builder missing "Build Query" button #16485

ibennetch opened this issue Nov 16, 2020 · 0 comments · Fixed by #16551
Assignees
@williamdes
Labels
Bug A problem or regression with an existing feature good first issue has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete help wanted
Projects
Designer issues
Milestone
5.1.0

Comments

@ibennetch
Copy link
Member

The Visual Query Builder is missing the "Build Query" button.

I have tested 5.0.2 and 4.9.7, but haven't yet gone down any further to find the commit that causes this.

5.0.2

image

4.9.7

image

To reproduce

  1. click on the Query tab for a database
  2. Click the "Query by example" second-level tab
  3. Follow the link to "Switch to visual builder"

The pop out menu should have a "Build Query" button, but doesn't.

First reported here: https://stackoverflow.com/questions/64813163/how-to-use-the-query-visual-builder-in-phpmyadmin
@williamdes williamdes added Bug A problem or regression with an existing feature good first issue help wanted labels Nov 16, 2020
@williamdes williamdes added this to the 5.1.0 milestone Nov 16, 2020
@williamdes williamdes added this to Needs triage in issues via automation Nov 16, 2020
@williamdes williamdes moved this from Needs triage to High priority in issues Nov 16, 2020
@williamdes williamdes added this to To Do in Designer Nov 16, 2020
Pauldro added a commit to Pauldro/phpmyadmin that referenced this issue Dec 29, 2020
@Pauldro
Added "Build Query" button to Visual Query Builder phpmyadmin#16485
577ebda 
There was a ```if not visual_builder ``` that kept it from displaying. I did a search to see if that value is supplied and what it would mean.
@Pauldro Pauldro mentioned this issue Dec 29, 2020
Closed
6 tasks
Pauldro added a commit to Pauldro/phpmyadmin that referenced this issue Dec 29, 2020
@Pauldro
Added "Build Query" button to Visual Query Builder phpmyadmin#16485
274510c 
There was a ```if not visual_builder ``` that kept it from displaying. I did a search to see if that value is supplied and what it would mean.

Signed-off-by: Paul Gomez <pauldro952@hotmail.com>
williamdes pushed a commit to Pauldro/phpmyadmin that referenced this issue Dec 29, 2020
@Pauldro @williamdes
Added "Build Query" button to Visual Query Builder phpmyadmin#16485
3138959 
There was a ```if not visual_builder ``` that kept it from displaying. I did a search to see if that value is supplied and what it would mean.
@williamdes williamdes added the has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete label Dec 29, 2020
Pauldro added a commit to Pauldro/phpmyadmin that referenced this issue Dec 29, 2020
@Pauldro
Added "Build Query" button to Visual Query Builder phpmyadmin#16485
20bc13b 
There was a ```if not visual_builder ``` that kept it from displaying. I did a search to see if that value is supplied and what it would mean.

Signed-off-by: Paul Gomez <pauldro952@hotmail.com>
@Pauldro Pauldro mentioned this issue Dec 29, 2020
Merged
6 tasks
@williamdes williamdes added has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete and removed has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete labels Dec 29, 2020
Pauldro added a commit to Pauldro/phpmyadmin that referenced this issue Dec 29, 2020
@Pauldro
Added "Build Query" button to Visual Query Builder phpmyadmin#16485
5c6c0ce 
There was a ```if not visual_builder ``` that kept it from displaying. I did a search to see if that value is supplied and what it would mean.

Amended to remove trailing whitespace.

Signed-off-by: Paul Gomez <pauldro952@hotmail.com>
williamdes pushed a commit to Pauldro/phpmyadmin that referenced this issue Dec 29, 2020
@Pauldro @williamdes
Added "Build Query" button to Visual Query Builder phpmyadmin#16485
94a4345 
There was a ```if not visual_builder ``` that kept it from displaying. I did a search to see if that value is supplied and what it would mean.

Signed-off-by: Paul Gomez <pauldro952@hotmail.com>
williamdes pushed a commit to Pauldro/phpmyadmin that referenced this issue Dec 31, 2020
@Pauldro @williamdes
Added "Build Query" button to Visual Query Builder phpmyadmin#16485
23e23e3 
There was a ```if not visual_builder ``` that kept it from displaying. I did a search to see if that value is supplied and what it would mean.

Signed-off-by: Paul Gomez <pauldro952@hotmail.com>
williamdes added a commit that referenced this issue Dec 31, 2020
@williamdes
Add a ChangeLog entry for #16485
463eec3 
Signed-off-by: William Desportes <williamdes@wdes.fr>
issues automation moved this from High priority to Closed Dec 31, 2020
@williamdes williamdes self-assigned this Dec 31, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@williamdes williamdes

Labels
Bug A problem or regression with an existing feature good first issue has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete help wanted
Projects
Designer
To Do
issues
  
Closed
Milestone
5.1.0
Development

Successfully merging a pull request may close this issue.

Added "Build Query" button to Visual Query Builder phpmyadmin#16485 Pauldro/phpmyadmin
2 participants
@ibennetch @williamdes