Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent empty list behaviour after dropping multiple routines/events/triggers #16498

Closed
petrduda opened this issue Nov 23, 2020 · 0 comments · Fixed by #16507
Closed

Inconsistent empty list behaviour after dropping multiple routines/events/triggers #16498

petrduda opened this issue Nov 23, 2020 · 0 comments · Fixed by #16507
Assignees
Labels
Bug A problem or regression with an existing feature good first issue has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete ui Issues relating to the user interface
Projects
Milestone

Comments

@petrduda
Copy link
Contributor

petrduda commented Nov 23, 2020

Describe the bug

When dropping all remaining routines/events/triggers, the resulting empty list is not replaced accordingly.

To Reproduce

Steps to reproduce the behavior:

  1. Select a database, create a few stored procedures (or events, or triggers, respectively), e.g.:
CREATE FUNCTION `test1`() RETURNS INT(1) NOT DETERMINISTIC NO SQL SQL SECURITY DEFINER RETURN 1; 
CREATE FUNCTION `test2`() RETURNS INT(1) NOT DETERMINISTIC NO SQL SQL SECURITY DEFINER RETURN 1; 
CREATE FUNCTION `test3`() RETURNS INT(1) NOT DETERMINISTIC NO SQL SQL SECURITY DEFINER RETURN 1; 
  1. Go to the Routines page.
  2. Select all the displayed routines, click "With selected: Drop", click "OK" in the pop-up confirm "Do you really want to delete the selected items?".
  3. The procedures are dropped and their rows are removed from the list correctly, but the list header/footer remains displayed.
  4. On the other hand, when deleting a single remaining procedure, the empty list is correctly replaced with a text "There are no routines to display."

Expected behavior

After dropping all routines, the empty list is consistently replaced with the "There are no routines to display." text.

Screenshots

After deleting multiple routines:
after-deleting-multiple

After deleting single remaining routine:
after-deleting-single

Server configuration

Client configuration

  • Browser: Firefox 83.0
  • Operating system: Ubuntu 20.04
@williamdes williamdes added Bug A problem or regression with an existing feature good first issue ui Issues relating to the user interface labels Nov 23, 2020
@williamdes williamdes added this to the 5.1.0 milestone Nov 23, 2020
@williamdes williamdes added this to Needs triage in issues via automation Nov 23, 2020
@williamdes williamdes moved this from Needs triage to n/a priority in issues Nov 23, 2020
@williamdes williamdes added the has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete label Nov 28, 2020
@williamdes williamdes self-assigned this Dec 7, 2020
williamdes added a commit that referenced this issue Dec 7, 2020
Closes: #16467 with 8fddd36

Signed-off-by: William Desportes <williamdes@wdes.fr>
issues automation moved this from n/a priority to Closed Dec 7, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug A problem or regression with an existing feature good first issue has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete ui Issues relating to the user interface
Projects
issues
  
Closed
Development

Successfully merging a pull request may close this issue.

2 participants