Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP 8.0 tests failing #16525

Closed
williamdes opened this issue Dec 10, 2020 · 1 comment
Closed

PHP 8.0 tests failing #16525

williamdes opened this issue Dec 10, 2020 · 1 comment
Assignees
@williamdes
Labels
Bug A problem or regression with an existing feature
Projects
issues
Milestone
5.1.0

Comments

@williamdes
Copy link
Member

williamdes commented Dec 10, 2020 •
edited 

williamdes@williamdes:/mnt/Dev/@phpmyadmin/theREALphpMyAdminREPO$ /bin/php8.0 ./vendor/bin/phpunit --no-coverage --exclude=selenium --filter="(GisPointTest|GisMultiPointTest)"
PHP Deprecated:  Required parameter $currentfont follows optional parameter $isunicode in /mnt/Dev/@phpmyadmin/theREALphpMyAdminREPO/vendor/tecnickcom/tcpdf/include/tcpdf_fonts.php on line 1998
PHP Deprecated:  Required parameter $currentfont follows optional parameter $isunicode in /mnt/Dev/@phpmyadmin/theREALphpMyAdminREPO/vendor/tecnickcom/tcpdf/include/tcpdf_fonts.php on line 2024
PHP Deprecated:  Required parameter $currentfont follows optional parameter $setbom in /mnt/Dev/@phpmyadmin/theREALphpMyAdminREPO/vendor/tecnickcom/tcpdf/include/tcpdf_fonts.php on line 2040
PHP Deprecated:  Required parameter $currentfont follows optional parameter $setbom in /mnt/Dev/@phpmyadmin/theREALphpMyAdminREPO/vendor/tecnickcom/tcpdf/include/tcpdf_fonts.php on line 2060
PHP Deprecated:  Required parameter $currentfont follows optional parameter $str in /mnt/Dev/@phpmyadmin/theREALphpMyAdminREPO/vendor/tecnickcom/tcpdf/include/tcpdf_fonts.php on line 2077
PHP Deprecated:  Required parameter $currentfont follows optional parameter $str in /mnt/Dev/@phpmyadmin/theREALphpMyAdminREPO/vendor/tecnickcom/tcpdf/include/tcpdf_fonts.php on line 2093
PHP Deprecated:  Required parameter $tagvspaces follows optional parameter $default_css in /mnt/Dev/@phpmyadmin/theREALphpMyAdminREPO/vendor/tecnickcom/tcpdf/include/tcpdf_static.php on line 1139
PHP Deprecated:  Required parameter $k follows optional parameter $points in /mnt/Dev/@phpmyadmin/theREALphpMyAdminREPO/vendor/tecnickcom/tcpdf/include/tcpdf_static.php on line 2510
PHPUnit 9.5.0 by Sebastian Bergmann and contributors.

Runtime:       PHP 8.0.0
Configuration: /mnt/Dev/@phpmyadmin/theREALphpMyAdminREPO/phpunit.xml.dist
Warning:       Your XML configuration validates against a deprecated schema.
Suggestion:    Migrate your XML configuration using "--migrate-configuration"!

...F.......F....                                                  16 / 16 (100%)

Time: 00:00.047, Memory: 48.00 MB

There were 2 failures:

1) PhpMyAdmin\Tests\Gis\GisMultiPointTest::testPrepareRowAsSvg with data set #0 ('MULTIPOINT(12 35,48 75,69 23,...35 78)', 'svg', '#B02EE0', array(12, 69, 2, 150), '/^(<circle cx="72" cy="138" r...\/>)$/')
Failed asserting that 0 matches expected 1.

/mnt/Dev/@phpmyadmin/theREALphpMyAdminREPO/test/classes/Gis/GisMultiPointTest.php:302

2) PhpMyAdmin\Tests\Gis\GisPointTest::testPrepareRowAsSvg with data set #0 ('POINT(12 35)', 'svg', '#B02EE0', array(12, 69, 2, 150), '')
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-''
+'<circle cx="0" cy="218" r="3" name="svg" id="svg1453261061" class="point vector" fill="white" stroke="#B02EE0" stroke-width="2"/>'

/mnt/Dev/@phpmyadmin/theREALphpMyAdminREPO/test/classes/Gis/GisPointTest.php:314

FAILURES!
Tests: 16, Assertions: 16, Failures: 2.

https://travis-ci.org/github/phpmyadmin/phpmyadmin/jobs/748483400#L1129
https://travis-ci.org/github/phpmyadmin/phpmyadmin/jobs/748483402#L1309
@williamdes
Copy link
Member Author

Here is why

diff --git a/libraries/classes/Gis/GisMultiPoint.php b/libraries/classes/Gis/GisMultiPoint.php
index 216720ff48..4d83a3c3aa 100644
--- a/libraries/classes/Gis/GisMultiPoint.php
+++ b/libraries/classes/Gis/GisMultiPoint.php
@@ -227,6 +227,9 @@ class GisMultiPoint extends GisGeometry
             );
         $points_arr = $this->extractPoints($multipoint, $scale_data);
 
+        die (json_encode([
+            $points_arr[0][0] == '',
+        ], JSON_PRETTY_PRINT));
         $row = '';
         foreach ($points_arr as $point) {
             if ($point[0] == '' || $point[1] == '') {
williamdes@williamdes:/mnt/Dev/@phpmyadmin/theREALphpMyAdminREPO$ /bin/ph8.04 ./vendor/bin/phpunit --no-coverage --exclude=selenium --filter="(GisPointTest|GisMultiPointTest)"
PHP Deprecated:  Required parameter $currentfont follows optional parameter $isunicode in /mnt/Dev/@phpmyadmin/theREALphpMyAdminREPO/vendor/tecnickcom/tcpdf/include/tcpdf_fonts.php on line 1998
PHP Deprecated:  Required parameter $currentfont follows optional parameter $isunicode in /mnt/Dev/@phpmyadmin/theREALphpMyAdminREPO/vendor/tecnickcom/tcpdf/include/tcpdf_fonts.php on line 2024
PHP Deprecated:  Required parameter $currentfont follows optional parameter $setbom in /mnt/Dev/@phpmyadmin/theREALphpMyAdminREPO/vendor/tecnickcom/tcpdf/include/tcpdf_fonts.php on line 2040
PHP Deprecated:  Required parameter $currentfont follows optional parameter $setbom in /mnt/Dev/@phpmyadmin/theREALphpMyAdminREPO/vendor/tecnickcom/tcpdf/include/tcpdf_fonts.php on line 2060
PHP Deprecated:  Required parameter $currentfont follows optional parameter $str in /mnt/Dev/@phpmyadmin/theREALphpMyAdminREPO/vendor/tecnickcom/tcpdf/include/tcpdf_fonts.php on line 2077
PHP Deprecated:  Required parameter $currentfont follows optional parameter $str in /mnt/Dev/@phpmyadmin/theREALphpMyAdminREPO/vendor/tecnickcom/tcpdf/include/tcpdf_fonts.php on line 2093
PHP Deprecated:  Required parameter $tagvspaces follows optional parameter $default_css in /mnt/Dev/@phpmyadmin/theREALphpMyAdminREPO/vendor/tecnickcom/tcpdf/include/tcpdf_static.php on line 1139
PHP Deprecated:  Required parameter $k follows optional parameter $points in /mnt/Dev/@phpmyadmin/theREALphpMyAdminREPO/vendor/tecnickcom/tcpdf/include/tcpdf_static.php on line 2510
PHPUnit 9.5.0 by Sebastian Bergmann and contributors.

Runtime:       PHP 8.0.0
Configuration: /mnt/Dev/@phpmyadmin/theREALphpMyAdminREPO/phpunit.xml.dist
Warning:       Your XML configuration validates against a deprecated schema.
Suggestion:    Migrate your XML configuration using "--migrate-configuration"!

...[
    false
]williamdes@williamdes:/mnt/Dev/@phpmyadmin/theREALphpMyAdminREPO$ /bin/ph7.40 ./vendor/bin/phpunit --no-coverage --exclude=selenium --filter="(GisPointTest|GisMultiPointTest)"
PHPUnit 9.5.0 by Sebastian Bergmann and contributors.

Runtime:       PHP 7.4.13
Configuration: /mnt/Dev/@phpmyadmin/theREALphpMyAdminREPO/phpunit.xml.dist
Warning:       Your XML configuration validates against a deprecated schema.
Suggestion:    Migrate your XML configuration using "--migrate-configuration"!

...[
    true
]

@williamdes williamdes self-assigned this Dec 10, 2020
@williamdes williamdes added the Bug A problem or regression with an existing feature label Dec 10, 2020
@williamdes williamdes added this to the 5.1.0 milestone Dec 10, 2020
@williamdes williamdes added this to Needs triage in issues via automation Dec 10, 2020
@williamdes williamdes moved this from Needs triage to Closed in issues Dec 10, 2020
williamdes added a commit that referenced this issue Dec 12, 2020
@williamdes
Fix #16525 - PHP 8.0 failing tests when comparing 0 to ''
bdc8760 
Signed-off-by: William Desportes <williamdes@wdes.fr>
williamdes added a commit that referenced this issue Dec 12, 2020
@williamdes
Add ChangeLog entries for #16525, #16429 and #16490
96f1a24 
Signed-off-by: William Desportes <williamdes@wdes.fr>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@williamdes williamdes

Labels
Bug A problem or regression with an existing feature
Projects
issues
  
Closed
Milestone
5.1.0
Development

No branches or pull requests
1 participant
@williamdes