Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating events should use 'DROP EVENT IF EXISTS' #16565

Closed
jeroenvernooij opened this issue Jan 12, 2021 · 2 comments · Fixed by #16569
Closed

Updating events should use 'DROP EVENT IF EXISTS' #16565

jeroenvernooij opened this issue Jan 12, 2021 · 2 comments · Fixed by #16569
Assignees
@williamdes
Labels
Bug A problem or regression with an existing feature has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete
Projects
issues
Milestone
5.1.0

Comments

@jeroenvernooij
Copy link

Apparently, when updating an event in phpMyAdmin, it issues a DROP EVENT `event_name` statement before the CREATE EVENT `event_name`.

This can cause problems in replication in Google CloudSQL migrations as they don't migrate SQL-Events to read-replica instances.
Thereby the replication fails beyond repair as it runs into an SQL error.

It would be more appropriate if phpMyAdmin will use DROP EVENT IF EXISTS `event_name`
@roccivic roccivic mentioned this issue Jan 13, 2021
Merged
@williamdes williamdes added Bug A problem or regression with an existing feature has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete labels Jan 13, 2021
@williamdes williamdes added this to the 5.1.0 milestone Jan 13, 2021
@williamdes williamdes added this to Needs triage in issues via automation Jan 13, 2021
@williamdes williamdes moved this from Needs triage to ready to merge in issues Jan 13, 2021
@williamdes
Copy link
Member

Hi @jeroenvernooij
Thanks for reporting that !
A fix is available and next version should be fixed after I merge it

@williamdes williamdes self-assigned this Jan 13, 2021
@williamdes williamdes linked a pull request Jan 13, 2021 that will close this issue
Added IF EXISTS clause to DROP EVENT statement when editing event. #16569
Merged
williamdes added a commit that referenced this issue Jan 13, 2021
@williamdes
Merge #16569 - Fix #16565 - Updating events should use 'DROP EVENT IF…
52438a7 
… EXISTS'

Pull-request: #16569
Fixes: #16565

Signed-off-by: William Desportes <williamdes@wdes.fr>
williamdes added a commit that referenced this issue Jan 13, 2021
@williamdes
Add a ChangeLog entry for #16565
a453cce 
Signed-off-by: William Desportes <williamdes@wdes.fr>
issues automation moved this from ready to merge to Closed Jan 13, 2021
@jeroenvernooij
Copy link
Author

Thanks @williamdes , much appreciated.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@williamdes williamdes

Labels
Bug A problem or regression with an existing feature has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete
Projects
issues
  
Closed
Milestone
5.1.0
Development

Successfully merging a pull request may close this issue.

Added IF EXISTS clause to DROP EVENT statement when editing event. roccivic/phpmyadmin
2 participants
@williamdes @jeroenvernooij