Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Table action links takes all the place on a big screen #16604

Closed
OlafvdSpek opened this issue Jan 29, 2021 · 5 comments · Fixed by #16718
Closed

Table action links takes all the place on a big screen #16604

OlafvdSpek opened this issue Jan 29, 2021 · 5 comments · Fixed by #16718
Assignees
@williamdes
Labels
Bug A problem or regression with an existing feature has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete help wanted ui Issues relating to the user interface
Projects
issues
Milestone
5.1.1

Comments

@OlafvdSpek
Copy link

5.1.0-rc1

This doesn't look right.

image
@williamdes williamdes added ui Issues relating to the user interface undecided labels Jan 29, 2021
@OlafvdSpek OlafvdSpek mentioned this issue Feb 25, 2021
Closed
@williamdes williamdes added Bug A problem or regression with an existing feature help wanted and removed undecided labels Feb 25, 2021
@williamdes williamdes added this to the 5.1.1 milestone Feb 25, 2021
@williamdes williamdes added this to n/a priority in issues Feb 25, 2021
@williamdes williamdes changed the title Stretched tables Table action links takes all the place on a big screen Feb 25, 2021
@williamdes williamdes mentioned this issue Mar 5, 2021
Closed
@nunoperalta
Copy link

Same happens with the list of indexes, by the way (in the Table Structure page)

@linaspasv
Copy link

Oh, I was about to report this as a potential bug... this does not look right. I would prefer the old look (or atleast an option to rollback).

@linaspasv
Copy link

@williamdes I guess the w-auto class is missing on most of the tables right now - browse, structure, index, relation view and other tables. Atleast that's what is used on database's tables table right now. By default Bootstrap table theme is 100% width and I see you switched to BT table classes at some point where it was a custom style before.

@williamdes
Copy link
Member

@williamdes I guess the w-auto class is missing on most of the tables right now - browse, structure, index, relation view and other tables. Atleast that's what is used on database's tables table right now. By default Bootstrap table theme is 100% width and I see you switched to BT table classes at some point where it was a custom style before.

Thanks for the feedback
Indeed this needs to be fixed, most users do not like this change

@shucon shucon mentioned this issue Mar 6, 2021
Merged
6 tasks
@williamdes williamdes added the has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete label Mar 6, 2021
@williamdes williamdes mentioned this issue Mar 14, 2021
Closed
williamdes added a commit that referenced this issue Mar 14, 2021
@williamdes
Merge #16718 - Fix #16604 - set table width to 100%
1caae2c 
Pull-request: #16718
Fixes: #16604
Fixes: #16684
Fixes: #16733

Signed-off-by: William Desportes <williamdes@wdes.fr>
williamdes added a commit that referenced this issue Mar 14, 2021
@williamdes
Add a ChangeLog entry for #16604
5b60045 
Ref: #16684
Ref: #16733

Signed-off-by: William Desportes <williamdes@wdes.fr>
@williamdes williamdes self-assigned this Mar 14, 2021
williamdes added a commit that referenced this issue Mar 14, 2021
@williamdes
Fix #16604 - set back table width to auto
7c7bd65 
Signed-off-by: William Desportes <williamdes@wdes.fr>
issues automation moved this from n/a priority to Closed Mar 14, 2021
@ibennetch
Copy link
Member

ibennetch commented Mar 15, 2021 via email

williamdes added a commit that referenced this issue Apr 1, 2021
@williamdes
Fix #16604 - set back table width to auto on zoom search page
3fc01f6 
Signed-off-by: William Desportes <williamdes@wdes.fr>
williamdes added a commit that referenced this issue Apr 1, 2021
@williamdes
Add ChangeLog entries for #16604, 700108b, 8597ec6, ec04f6ebac
26cca21 
Entry for #16604 already exists

Signed-off-by: William Desportes <williamdes@wdes.fr>
@williamdes williamdes mentioned this issue Apr 1, 2021
Merged
6 tasks
williamdes added a commit that referenced this issue Apr 2, 2021
@williamdes
Merge #16787 - Ref #16604 - Fix table width in Databases page
61499f9 
Pull-request: #16787
Ref: #16604

Signed-off-by: William Desportes <williamdes@wdes.fr>
@williamdes williamdes mentioned this issue Apr 13, 2021
Closed
@williamdes williamdes mentioned this issue Apr 13, 2021
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@williamdes williamdes

Labels
Bug A problem or regression with an existing feature has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete help wanted ui Issues relating to the user interface
Projects
issues
  
Closed
Milestone
5.1.1
Development

Successfully merging a pull request may close this issue.

Fix #16604 - Table width 100% shucon/phpmyadmin
5 participants
@nunoperalta @linaspasv @ibennetch @OlafvdSpek @williamdes