Vertical alignment seems off

[OlafvdSpek]

5.1.0-rc1

Vertical alignment of the table names seems off.
Same for the sum values of rows, size and overhead. Font size of these seems off too.

[rajpratyush]

Hi @williamdes I would like to work on this issue if it is still open ? Also I would like to have some insight and context of the problem.

[williamdes]

Hi @williamdes I would like to work on this issue if it is still open ? Also I would like to have some insight and context of the problem.

Hi @rajpratyush it is still open and you can work on it
You can find the issue reported when browsing the table list of a database

[rajpratyush]

@williamdes can you tell me the files associated with this and tell them where they are located. And kindly assign me the issue

[williamdes]

@williamdes can you tell me the files associated with this and tell them where they are located. And kindly assign me the issue

I think you should start be checking CSS differences between demo servers to find out what to search for in the code.

Demo servers (root, no password)

• 5.2.0-dev
• 5.1.x-dev
• 5.0.x-dev
• 4.9.x

[rajpratyush]

Sure

[bradsi]

Hi, @williamdes I've had a play around with the CSS and I've got a fix for this. First time contributing to OSS so wanted to make sure I can work on it. Please could you assign me the issue if so?

[williamdes]

Hi, @williamdes I've had a play around with the CSS and I've got a fix for this. First time contributing to OSS so wanted to make sure I can work on it. Please could you assign me the issue if so?

Hi @bradsi
Thank you for contributing, for sure you can work on it :)
Let us know your progress and if you stopped working on it

[bradsi]

@williamdes is this going into QA_5_1?
I've forked, pulled from main and made a branch for changes, but PR is showing 948 files changed so I think I've done something wrong. Do I need to pull from QA_5_1 instead of main? Sorry for the stupid question.

[OlafvdSpek]

Isn't master affected (too)?

[williamdes]

@williamdes is this going into QA_5_1?
I've forked, pulled from main and made a branch for changes, but PR is showing 948 files changed so I think I've done something wrong. Do I need to pull from QA_5_1 instead of main? Sorry for the stupid question.

Seems like you sorted it out 👍🏻
I think it should go into QA_5_1, your PR is fine :)

[OlafvdSpek]

Isn't master affected (too)?

https://demo.phpmyadmin.net/master-config/index.php?route=/database/structure&server=2&db=mysql

[williamdes]

Isn't master affected (too)?

https://demo.phpmyadmin.net/master-config/index.php?route=/database/structure&server=2&db=mysql

Seems like you are right, maybe the rule does not apply because the th is in a tr

[bradsi]

Is demo on a different release as this change has only affected 5.1.1 so maybe the changes aren't reflecting on demo?

[williamdes]

Is demo on a different release as this change has only affected 5.1.1 so maybe the changes aren't reflecting on demo?

I merged QA_5_1 into master, I can confirm the changes are there but seem not to work

[bradsi]

I will look into it and get a fix