Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sql.rearrangeStickyColumns is not a function #16609

Closed
sleepm opened this issue Feb 1, 2021 · 5 comments
Closed

Sql.rearrangeStickyColumns is not a function #16609

sleepm opened this issue Feb 1, 2021 · 5 comments
Assignees
@williamdes
Labels
Bug A problem or regression with an existing feature
Projects
issues
Milestone
5.1.0

Comments

@sleepm
Copy link

sleepm commented Feb 1, 2021

Describe the bug

A clear and concise description of what the bug is.

To Reproduce

Steps to reproduce the behavior:

  1. Go to 'table'
  2. double Click on field value'
  3. See error in console

rearrangeStickyColumns not defined in /js/sql.js?v=5.0.4
@williamdes
Copy link
Member

Hi @sleepm
Would you mind trying out 5.1.0-rc1 version or it's snapshot (more up to date) ?
You can download it on our website: phpMyAdmin 5.1+snapshot

@williamdes williamdes added the question Used when we need feedback from the submitter or when the issue is a question about PMA label Feb 1, 2021
@williamdes williamdes added this to Needs triage in Questions via automation Feb 1, 2021
@williamdes williamdes moved this from Needs triage to waiting... in Questions Feb 1, 2021
@sleepm
Copy link
Author

sleepm commented Feb 2, 2021

same issue
double click on column name to copy,
open f12 console see
Uncaught TypeError: Sql.rearrangeStickyColumns is not a function

@sleepm
Copy link
Author

sleepm commented Feb 2, 2021

makegrid depends on rearrangeStickyColumns
https://github.com/phpmyadmin/phpmyadmin/blob/master/js/src/makegrid.js#L232

@williamdes
Copy link
Member

I searched and the function was removed in #16277
Fixing this in QA_5_0 even if next release will be 5.1.0

@williamdes williamdes self-assigned this Feb 2, 2021
@williamdes williamdes added Bug A problem or regression with an existing feature and removed question Used when we need feedback from the submitter or when the issue is a question about PMA labels Feb 2, 2021
@williamdes williamdes added this to the 5.0.5 milestone Feb 2, 2021
@williamdes williamdes added this to Needs triage in issues via automation Feb 2, 2021
@williamdes williamdes removed this from waiting... in Questions Feb 2, 2021
@williamdes williamdes moved this from Needs triage to Medium priority in issues Feb 2, 2021
williamdes added a commit that referenced this issue Feb 2, 2021
@williamdes
Fix #16609 - Remove CSS left-overs of #16277
076651c 
Signed-off-by: William Desportes <williamdes@wdes.fr>
williamdes added a commit that referenced this issue Feb 2, 2021
@williamdes
Add a ChangeLog entry for #16609
501e88d 
Signed-off-by: William Desportes <williamdes@wdes.fr>
issues automation moved this from Medium priority to Closed Feb 2, 2021
@williamdes
Copy link
Member

Thank you @sleepm for your report !

@ibennetch ibennetch modified the milestones: 5.0.5, 5.1.0 Jan 22, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@williamdes williamdes

Labels
Bug A problem or regression with an existing feature
Projects
issues
  
Closed
Milestone
5.1.0
Development

No branches or pull requests
3 participants
@ibennetch @williamdes @sleepm