Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to add tables to rename aliases twice on Export #16611

Closed
ChrisHSandN opened this issue Feb 1, 2021 · 6 comments · Fixed by #16613
Closed

Unable to add tables to rename aliases twice on Export #16611

ChrisHSandN opened this issue Feb 1, 2021 · 6 comments · Fixed by #16613
Assignees
Labels
Bug A problem or regression with an existing feature has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete
Projects
Milestone

Comments

@ChrisHSandN
Copy link

ChrisHSandN commented Feb 1, 2021

Describe the bug

The rename exported... checkbox on the export tab fails to do anything.

To Reproduce

Steps to reproduce the behavior:

  1. Go to any table with rows e.g. mysql.db
  2. Click on the Export tab
    Export Method: Custom - display all possible options
    Format: SQL
    Output: Rename exported databases/tables/columns
  3. Enter anything into "Select database" and "Select Table"
  4. Save And Close

Rename exported databases/tables/columns checkbox remains unticked (and is impossible to tick). While exported SQL file does not use the new table/database names.

Expected behavior

Rename exported databases/tables/columns checkbox should be checked after saving and the output SQL file should have the given names for db and table.

Screenshots

image
image

Server configuration

Client configuration

  • Browser: Chrome Latest
  • Operating system: Windows 10
@williamdes williamdes added the Bug A problem or regression with an existing feature label Feb 1, 2021
@williamdes williamdes added this to the 5.1.0 milestone Feb 1, 2021
@williamdes williamdes added this to Needs triage in issues via automation Feb 1, 2021
@williamdes williamdes moved this from Needs triage to to be fixed soon in issues Feb 1, 2021
@williamdes
Copy link
Member

Thank you @ChrisHSandN for the report !
@shucon would you have a look please ?

@shucon
Copy link
Contributor

shucon commented Feb 2, 2021

Sure!

@williamdes williamdes self-assigned this Feb 2, 2021
@williamdes williamdes added the has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete label Feb 2, 2021
@williamdes
Copy link
Member

Hi @ChrisHSandN
On the steps to follow you did no say to click on "Add", did you do it ?

@ChrisHSandN
Copy link
Author

Hi @williamdes,

The server I initially found this bug on was a 5.0.1 and it seems the Add buttons were broken on that release - so when I re-tested it on your 5.0.5-dev sever I just assumed you didn't need to press Add when setting a db/table alias 🤦‍♂️. Going back and pressing "Add" it works as expected.

Closing, sorry for wasting your time and thanks for your prompt responses.

issues automation moved this from to be fixed soon to Closed Feb 3, 2021
@shucon
Copy link
Contributor

shucon commented Feb 3, 2021

One thing that I noticed while reproducing this was that the add buttons worked only once. If you close the modal, open it again, remove the rows and then try again to add the names, it won't happen. So I've fixed that issue in the above PR.

@williamdes
Copy link
Member

One thing that I noticed while reproducing this was that the add buttons worked only once. If you close the modal, open it again, remove the rows and then try again to add the names, it won't happen. So I've fixed that issue in the above PR.

I can confirm that, thank you !
Merging your fix, it works great

@williamdes williamdes changed the title Rename exported databases/tables/columns checkbox does not work Unable to add tables to rename twice on Export Feb 5, 2021
@williamdes williamdes reopened this Feb 5, 2021
issues automation moved this from Closed to Needs triage Feb 5, 2021
@williamdes williamdes changed the title Unable to add tables to rename twice on Export Unable to add tables to rename aliases twice on Export Feb 5, 2021
williamdes added a commit that referenced this issue Feb 5, 2021
Signed-off-by: William Desportes <williamdes@wdes.fr>
issues automation moved this from Needs triage to Closed Feb 5, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug A problem or regression with an existing feature has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete
Projects
issues
  
Closed
Development

Successfully merging a pull request may close this issue.

3 participants