No text on buttons on preferences page

[OlafvdSpek]

5.1.0-rc2

The icons look pretty, but I don't really know what each icon does without the text..

https://demo.phpmyadmin.net/master-config/index.php?route=/preferences/manage&lang=nl

$cfg['ActionLinksMode'] = 'icons';

[williamdes]

Not sure if this is a bug. You can use tooltips.

[ibennetch]

@OlafvdSpek I'm not sure what your point is — the default of is to have icons+text ('both'), so a user would have to intentionally choose to switch to 'icons'. We've tried to keep some consistency with the icons to their use across the rest of the application (SQL queries, import, export, etc), so even though for instance the "SQL queries" icon isn't very intuitive, it matches the icon used for the SQL tab so anyone working in 'icon' mode should know what they mean.

What solution do you propose?

[ibennetch]

Or perhaps your point is that this setting shouldn't affect these icons, which I agree with.

This is currently affected by $cfg['ActionLinksMode'], but should be $cfg['TabsMode'] instead.

[williamdes]

Or perhaps your point is that this setting shouldn't affect these icons, which I agree with.

This is currently affected by $cfg['ActionLinksMode'], but should be $cfg['TabsMode'] instead.

Thank you !
This will be fixed by 8c74a42

[OlafvdSpek]

Thanks!

[williamdes]

Thanks!

Let me know if you find more buttons affected

[OlafvdSpek]

Table - Search doesn't have text on the icons yet.

[williamdes]

Table - Search doesn't have text on the icons yet.

Indeed, fixed by ffb22f4