Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error messages are not translated #16656

Closed
williamdes opened this issue Feb 17, 2021 · 0 comments · Fixed by #16749
Closed

Error messages are not translated #16656

williamdes opened this issue Feb 17, 2021 · 0 comments · Fixed by #16749
Assignees
Labels
Bug A problem or regression with an existing feature good first issue has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete ui Issues relating to the user interface
Projects
Milestone

Comments

@williamdes
Copy link
Member

williamdes commented Feb 17, 2021

Describe the bug

Error messages are not translated

To Reproduce

image

Expected behavior

Be translated

Server configuration

  • phpMyAdmin version: 5.1

Dev details

The message seen in french is added with the rule in

jQuery.validator.addMethod('validationFunctionForMultipleInt', function (value) {
return value.match(/^(?:(?:\d\s*)|\s*)+(?:,\s*\d+)*$/i) !== null;
},
Messages.strEnterValidNumber
);

If this function was called and was doing its work that would fix this issue

function extendingValidatorMessages () {

Manually calling it (from dev console) does fix the issue, but this feels more like a hack because this is the only line supposed to call it

extendingValidatorMessages();

image

@williamdes williamdes added Bug A problem or regression with an existing feature ui Issues relating to the user interface good first issue labels Feb 17, 2021
@williamdes williamdes added this to the 5.1.1 milestone Feb 17, 2021
@williamdes williamdes added this to Needs triage in issues via automation Feb 17, 2021
@williamdes williamdes moved this from Needs triage to Reproduced in issues Feb 17, 2021
shucon added a commit to shucon/phpmyadmin that referenced this issue Mar 21, 2021
Signed-off-by: Saksham Gupta <shucon01@gmail.com>
shucon added a commit to shucon/phpmyadmin that referenced this issue Mar 21, 2021
Signed-off-by: Saksham Gupta <shucon01@gmail.com>
@williamdes williamdes added the has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete label Mar 22, 2021
@williamdes williamdes self-assigned this Mar 24, 2021
williamdes added a commit that referenced this issue Mar 24, 2021
Pull-request: #16749
Fixes: #16656

Signed-off-by: William Desportes <williamdes@wdes.fr>
williamdes added a commit that referenced this issue Mar 24, 2021
Signed-off-by: William Desportes <williamdes@wdes.fr>
issues automation moved this from Reproduced to Closed Mar 24, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug A problem or regression with an existing feature good first issue has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete ui Issues relating to the user interface
Projects
issues
  
Closed
Development

Successfully merging a pull request may close this issue.

1 participant