Query generation bug on QBE feature caught by our Selenium test suite

[williamdes]

Describe the bug

The query is wrong and the highlight is broken

To Reproduce

https://demo.phpmyadmin.net/QA_5_0/db_qbe.php?db=sakila&server=1

MariaDB

MySQL

Expected behavior

Like in MariaDB

Server configuration

• phpMyAdmin version: 5.0, 5.1, master

Dev

It seems like on MySQL the checkbox does not auto-tick "show" the column

#16479 (comment)

There was 1 failure:

1) PhpMyAdmin\Tests\Selenium\Database\QueryByExampleTest::testQueryByExample
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'SELECT `test_table`.`id` AS `ID`, `test_table`.`val` AS `VAL`\n
-FROM `test_table`\n
+'FROM `test_table`\n
 WHERE ((`test_table`.`id` > 1) AND (`test_table`.`val` < 6))\n
 ORDER BY `test_table`.`val` ASC, `test_table`.`id` DESC'

/home/runner/work/phpmyadmin/phpmyadmin/test/selenium/Database/QueryByExampleTest.php:121

[williamdes]

This is because of this line:

phpmyadmin/libraries/classes/Controllers/Database/QueryByExampleController.php

Line 54 in c11e8d5

$this->addScriptFiles(['database/qbe.js']);

if the storage is not installed, the script is not loaded