Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Column Drop arrow is not responsive #16659

Closed
sradhanjan opened this issue Feb 17, 2021 · 3 comments · Fixed by #16687
Closed

Column Drop arrow is not responsive #16659

sradhanjan opened this issue Feb 17, 2021 · 3 comments · Fixed by #16687
Assignees
@williamdes
Labels
Bug A problem or regression with an existing feature good first issue ui Issues relating to the user interface
Projects
issues
Milestone
5.1.1

Comments

@sradhanjan
Copy link

Describe the bug

Column drop arrow's position remains unchanged in header row when window is minimized.

To Reproduce

Steps to reproduce the behavior:

  1. Go to any database
  2. Choose any table

Expected behavior

column drop arrow should adjust itself with windows size.

Screenshots
(normal window)
Capture1

(after the window is minimized)
Capture2

Server configuration

  • Operating system: Windows
  • Web server: Xampp(localhost)
  • PHP version:7.4.6
  • phpMyAdmin version: 5.1.0

Client configuration

  • Browser:Google Chrome
  • Operating system: Windows
@williamdes williamdes added Bug A problem or regression with an existing feature ui Issues relating to the user interface labels Feb 17, 2021
@williamdes williamdes added this to Needs triage in issues via automation Feb 17, 2021
@williamdes williamdes moved this from Needs triage to Reproduced in issues Feb 17, 2021
@ujjwal-batra
Copy link
Contributor

@williamdes The div for the dropdown is outside the th tag if we will add it in the th tag I think it will responsive. Can you tell which file should I look for this change?

@williamdes
Copy link
Member

@williamdes The div for the dropdown is outside the th tag if we will add it in the th tag I think it will responsive. Can you tell which file should I look for this change?

Hi !
I think js/src/makegrid.js should be the one, you can find occurrences of cDrop in it

@ujjwal-batra
Copy link
Contributor

@williamdes yeah I found it. I will try to fix it

@ujjwal-batra ujjwal-batra mentioned this issue Feb 25, 2021
Closed
1 task
ujjwal-batra added a commit to ujjwal-batra/phpmyadmin that referenced this issue Feb 26, 2021
@ujjwal-batra
fixes phpmyadmin#16659
fba05d7 
Signed-off-by: ujjwal <ujjwal24batra@gmail.com>
@ujjwal-batra ujjwal-batra mentioned this issue Feb 26, 2021
Merged
6 tasks
williamdes added a commit that referenced this issue Mar 5, 2021
@williamdes
Merge #16687 - Fix #16659 - Column Drop arrow is not responsive
a4468f2 
Pull-request: #16687
Fixes: #16659

Signed-off-by: William Desportes <williamdes@wdes.fr>
williamdes added a commit that referenced this issue Mar 5, 2021
@williamdes
Add a ChangeLog entry for #16659
dac7a81 
Signed-off-by: William Desportes <williamdes@wdes.fr>
issues automation moved this from Reproduced to Closed Mar 5, 2021
williamdes added a commit that referenced this issue Mar 12, 2021
@williamdes
Fix #16659 - remove auto set left position for the dropdown position
5fbd98e 
It made the arrow not to be aligned with the dropdown, the user could not use the dropdown
Signed-off-by: William Desportes <williamdes@wdes.fr>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 6, 2022
@williamdes williamdes self-assigned this Oct 29, 2022
@williamdes williamdes added this to the 5.1.1 milestone Oct 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@williamdes williamdes

Labels
Bug A problem or regression with an existing feature good first issue ui Issues relating to the user interface
Projects
issues
  
Closed
Milestone
5.1.1
3 participants
@williamdes @ujjwal-batra @sradhanjan