Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UX issues in the Classic Theme #16677

Closed
nunoperalta opened this issue Feb 24, 2021 · 9 comments · Fixed by #16690
Closed

UX issues in the Classic Theme #16677

nunoperalta opened this issue Feb 24, 2021 · 9 comments · Fixed by #16690
Assignees
@williamdes
Labels
Bug A problem or regression with an existing feature good first issue help wanted ui Issues relating to the user interface
Projects
issues
Milestone
5.1.1

Comments

@nunoperalta
Copy link

The font size of the SQL query (when we open a table for example) seems to be smaller than before.
Almost unreadable.

image

The background of the Database structure (sidebar) is now white where the tables are (not sure if it was intentional)

image

Is it intentional that the results expand to 100% width when there aren't many columns?
I think I prefer when it didn't expand. I don't see any benefit in expanding, making it a bit harder to look at the results.

image

The "Hide" button makes the contents shift down when putting the mouse over a long table name:

image

image

(I wish I could remove the "Hide" button without having to use AdBlock to do it, by the way...)
@williamdes
Copy link
Member

Hi @nunoperalta
Version: 5.1.0 ?

@williamdes williamdes added Bug A problem or regression with an existing feature ui Issues relating to the user interface labels Feb 24, 2021
@nunoperalta
Copy link
Author

Sorry - yes! Forgot to mention. That's after the upgrade to 5.1.0 😁👍

@williamdes
Copy link
Member

Sorry - yes! Forgot to mention. That's after the upgrade to 5.1.0

Thank you 😄
@shucon would you mind having a look please ?

@williamdes williamdes added this to the 5.1.1 milestone Feb 24, 2021
@williamdes williamdes added this to Needs triage in issues via automation Feb 24, 2021
@williamdes williamdes moved this from Needs triage to to be fixed soon in issues Feb 24, 2021
@shucon
Copy link
Contributor

shucon commented Feb 24, 2021

Sure!

@magentox
Copy link

Same trouble with Metro theme: too small fonts, phpmyadmin logo on left size is awful and few more. On the other hand, pmahomme theme works perfectly fine, fonts are OK, logo is fine just like it was when it was 5.0.4.

@Draghmar
Copy link

Draghmar commented Mar 1, 2021 •
edited

For me each of the three themes has all those issues after updating to 5.1. Even at log-in screen.

@williamdes williamdes mentioned this issue Mar 5, 2021
Merged
@williamdes williamdes linked a pull request Mar 5, 2021 that will close this issue
Fix #16677 - Font size of SQL query #16690
Merged
williamdes added a commit that referenced this issue Mar 5, 2021
@williamdes
Ref #16677 - Prevent bootstrap from overriding the tree background
3a01452 
Signed-off-by: William Desportes <williamdes@wdes.fr>
@williamdes
Copy link
Member

The background of the Database structure (sidebar) is now white where the tables are (not sure if it was intentional)

Fixed by 3a01452

@williamdes williamdes self-assigned this Mar 5, 2021
@williamdes
Copy link
Member

Is it intentional that the results expand to 100% width when there aren't many columns?
I think I prefer when it didn't expand. I don't see any benefit in expanding, making it a bit harder to look at the results.

See #16604

williamdes added a commit that referenced this issue Mar 5, 2021
@williamdes
Merge #16690 - Fix #16677 - Font size of SQL query
5531ef2 
Pull-request: #16690
Fixes: #16677

Signed-off-by: William Desportes <williamdes@wdes.fr>
williamdes added a commit that referenced this issue Mar 5, 2021
@williamdes
Add ChangeLog entries for #16677, #16698 and #16713
e00c957 
Signed-off-by: William Desportes <williamdes@wdes.fr>
issues automation moved this from to be fixed soon to Closed Mar 5, 2021
@nunoperalta
Copy link
Author

Is it intentional that the results expand to 100% width when there aren't many columns?
I think I prefer when it didn't expand. I don't see any benefit in expanding, making it a bit harder to look at the results.

See #16604

Same happens with the list of indexes, by the way (in the Table Structure page)

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@williamdes williamdes

Labels
Bug A problem or regression with an existing feature good first issue help wanted ui Issues relating to the user interface
Projects
issues
  
Closed
Milestone
5.1.1
Development

Successfully merging a pull request may close this issue.

Fix #16677 - Font size of SQL query shucon/phpmyadmin
5 participants
@Draghmar @nunoperalta @williamdes @shucon @magentox