Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't see SQL after adding new column in 5.1.0 #16693

Closed
wotnotweb opened this issue Mar 1, 2021 · 8 comments · Fixed by #17089
Closed

Can't see SQL after adding new column in 5.1.0 #16693

wotnotweb opened this issue Mar 1, 2021 · 8 comments · Fixed by #17089
Assignees
Labels
Bug A problem or regression with an existing feature has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete ui Issues relating to the user interface
Projects
Milestone

Comments

@wotnotweb
Copy link

Describe the bug

Page refreshes immedaitely back to structure so can't see the SQL that was entered after adding a new column

To Reproduce

Steps to reproduce the behavior:

  1. Go to table structure tab
  2. Click Go to add column
  3. Enter details and click save
  4. Page refreshes immedaitely so can't see the SQL that was entered

Expected behavior

The refresh to the structure view is a good improvement but the SQL should still be displayed as it useful to copy for logging what was done.

Screenshots

Server configuration

  • Operating system: Linux
  • Web server: Apache
  • Database version: 5.5.68-MariaDB
  • PHP version: 7.3.27
  • phpMyAdmin version: 5.1.0

Client configuration

  • Browser: Firefox
  • Operating system: Win 10

Additional context

Add any other context about the problem here.

@williamdes williamdes added the ui Issues relating to the user interface label Mar 1, 2021
@williamdes williamdes added this to Triage zone in Enhancements via automation Mar 1, 2021
@williamdes
Copy link
Member

Hi @wotnotweb
Thank you for your comments on that, I agree that could be improved

@williamdes williamdes moved this from Triage zone to Interface in Enhancements Mar 1, 2021
@sradhanjan
Copy link

@wotnotweb You can click the console which is at the bottom left side of the page to check the SQL query you have just entered
(before)
image
(after clicking console)
image

@wotnotweb
Copy link
Author

Many thanks, I can use that, I'm just used to it being at the top after the change.

Incidentally there is one thing that has never been shown after an action which is the move columns interface. It is not shown at the top or in the console. I have to remember to use the preview SQL and copy it first if I need to replicate it.

@toxpal
Copy link

toxpal commented Mar 26, 2021

Came here to report the same. Version 5.1.0 actually displays SQL query at the top (just like old versions), but it does so for half a second, and then page refreshes, which is very annoying.

Devs, please bring the old behavior back.

@williamdes
Copy link
Member

cc @MauricioFauth what is your opinion ?

@williamdes williamdes removed this from Interface in Enhancements Mar 26, 2021
@williamdes williamdes added this to Needs triage in issues via automation Mar 26, 2021
@williamdes williamdes moved this from Needs triage to Reproduced in issues Mar 26, 2021
@toxpal
Copy link

toxpal commented Jun 22, 2021

The issue still exists in 5.1.1

@williamdes williamdes added the Bug A problem or regression with an existing feature label Aug 25, 2021
@williamdes williamdes added this to the 5.1.2 milestone Aug 25, 2021
@williamdes
Copy link
Member

As said in #17088 I thinks this is due to #15675
I marked this to be done soon as I take the reports about this behavior seriously. I understand it is annoying to not be able to copy the query

@williamdes
Copy link
Member

I just created #17089
Feel free to try it here: #17089 (comment)

@williamdes williamdes added the has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete label Aug 25, 2021
@williamdes williamdes self-assigned this Sep 2, 2021
williamdes added a commit that referenced this issue Sep 2, 2021
… the table structure on the same page

Fixes: #16693
Fixes: #12753

Pull-request: #17089

Signed-off-by: William Desportes <williamdes@wdes.fr>
williamdes added a commit that referenced this issue Sep 2, 2021
Signed-off-by: William Desportes <williamdes@wdes.fr>
issues automation moved this from Reproduced to Closed Sep 5, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug A problem or regression with an existing feature has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete ui Issues relating to the user interface
Projects
issues
  
Closed
4 participants