Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No SQL option on Export of rows from a table #16703

Closed
idonda opened this issue Mar 3, 2021 · 7 comments
Closed

No SQL option on Export of rows from a table #16703

idonda opened this issue Mar 3, 2021 · 7 comments
Assignees
@williamdes
Labels
Bug A problem or regression with an existing feature
Projects
issues
Milestone
5.1.1

Comments

@idonda
Copy link

idonda commented Mar 3, 2021

Describe the bug

Exporting rows from a table is not possible in SQL format, because the SQL option is not present in the menu.
The problem only shows up if we want to export some rows and not the entire table.
It seems the same kind of problem we had with tables in this issue: #14775

To Reproduce

Steps to reproduce the behavior:

  1. Go to database structure
  2. Click on a table
  3. Select 1 or more rows
  4. Click on the export button at the end of the row list

Expected behavior

It is expected to be able to export in sql format a number of rows and not only the entire table.

Screenshots

If applicable, add screenshots to help explain your problem.

Server configuration

  • Operating system:
  • Web server: Apache 2.4.29
  • Database version: mysql 5.0.12
  • PHP version: 7.3.4
  • phpMyAdmin version: 5.0.1

Client configuration

  • Browser: chrome
  • Operating system: macos

Additional context

This is working correctly in phpmyadmin 4.9.7
@williamdes williamdes added the Bug A problem or regression with an existing feature label Mar 7, 2021
@williamdes williamdes added this to Needs triage in issues via automation Mar 7, 2021
@williamdes williamdes moved this from Needs triage to High priority in issues Mar 7, 2021
@williamdes williamdes added this to the 5.1.1 milestone Mar 7, 2021
@goodspeed666
Copy link

It's a big problem, please fix it quickly.

@williamdes
Copy link
Member

It's a big problem, please fix it quickly.

We will do our best to fix it, from what I tested this bug exists in 5.0 versions and 4.9 versions.

@goodspeed666
Copy link

It's a big problem, please fix it quickly.

We will do our best to fix it, from what I tested this bug exists in 5.0 versions and 4.9 versions.

Hi @williamdes,

I rollback to 5.0.4, the function is work.

@shucon
Copy link
Contributor

shucon commented Mar 21, 2021

Working on it. 75397c9 is the first bad commit.

shucon added a commit to shucon/phpmyadmin that referenced this issue Mar 22, 2021
@shucon
Fix phpmyadmin#16703 No SQL option on Export of rows from a table
5d3ae82 
Signed-off-by: Saksham Gupta <shucon01@gmail.com>
@shucon shucon mentioned this issue Mar 22, 2021
Merged
6 tasks
shucon added a commit to shucon/phpmyadmin that referenced this issue Mar 22, 2021
@shucon
Fix phpmyadmin#16703 No SQL option on Export of rows from a table
659d41d 
Signed-off-by: Saksham Gupta <shucon01@gmail.com>

Add null fallback

Signed-off-by: Saksham Gupta <shucon01@gmail.com>
williamdes added a commit that referenced this issue Mar 23, 2021
@williamdes
Merge #16754 - Fix #16703 - No SQL option on Export of rows from a table
07ea06d 
Pull-request: #16754
Fixes: #16703

Signed-off-by: William Desportes <williamdes@wdes.fr>
williamdes added a commit that referenced this issue Mar 23, 2021
@williamdes
Add ChangeLog entries for 508c9d9, 9e73525, 71a0480, #16694, #14430 and
725496a 
#16703

Signed-off-by: William Desportes <williamdes@wdes.fr>
issues automation moved this from High priority to Closed Mar 23, 2021
@williamdes williamdes self-assigned this Mar 23, 2021
@williamdes
Copy link
Member

Hi @idonda
Could you download the latest 5.1 version snapshot (phpMyAdmin 5.1+snapshot) and let me know if this fixed the issue correctly ?

@idonda
Copy link
Author

idonda commented Mar 23, 2021

Hi @williamdes
I can confirm it does work.
I Installed the 5.1-snapshot (It reads 5.1.1-dev+20210323.4afbc67efa in the dashboard), I tried to export 3 rows out of a table and I can select the SQL option now. 👏👍

This fix will be included in the next stable version? thank you.

@williamdes
Copy link
Member

Hi @williamdes
I can confirm it does work.
I Installed the 5.1-snapshot (It reads 5.1.1-dev+20210323.4afbc67efa in the dashboard), I tried to export 3 rows out of a table and I can select the SQL option now. 👏👍

This fix will be included in the next stable version? thank you.

🎉
Sure, it will be in 5.1.1 version :)

@williamdes williamdes mentioned this issue Apr 19, 2021
Closed
This was referenced May 7, 2021
Closed
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@williamdes williamdes

Labels
Bug A problem or regression with an existing feature
Projects
issues
  
Closed
Milestone
5.1.1
Development

No branches or pull requests
4 participants
@goodspeed666 @williamdes @idonda @shucon