Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG][PHP8.0] error 500 in quick edit #16708

Closed
neoteknic opened this issue Mar 3, 2021 · 4 comments
Closed

[BUG][PHP8.0] error 500 in quick edit #16708

neoteknic opened this issue Mar 3, 2021 · 4 comments
Assignees
Labels
Bug A problem or regression with an existing feature has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete
Projects
Milestone

Comments

@neoteknic
Copy link

neoteknic commented Mar 3, 2021

500 Error on quick EDIT a field in a table

Bug in quick edit, eror 500
But the field is saved, not possible to quick edit after, have to reload to use quick edit again.

Error log

AH01071: Got error 'PHP message: PHP Fatal error:  Uncaught TypeError: hash_hmac(): Argument #2 ($data) must be of type string, array given in libraries/classes/Core.php:1285
Stack trace:
#0 libraries/classes/Core.php(1285): hash_hmac()
#1 libraries/classes/InsertEdit.php(2606): PhpMyAdmin\\Core::signSqlQuery()
#2 libraries/classes/Controllers/Table/ReplaceController.php(554): PhpMyAdmin\\InsertEdit->transformEditedValues()
#3 libraries/classes/Routing.php(186): PhpMyAdmin\\Controllers\\Table\\ReplaceController->index()
#4 index.php(18): PhpMyAdmin\\Routing::callControllerForRoute()
#5 {main}
  thrown in libraries/classes/Core.php on line 1285'

To Reproduce

Steps to reproduce the behavior:

  1. Go to index.php?route=/sql&db=DB&table=TABLE&pos=0
  2. Double click a field for quick editing and unfocus to send the query
  3. query post /index.php?route=/table/replace error 500

Expected behavior

No 500 error

Screenshots

image

Server configuration

  • Operating system: Gentoo up to date
  • Web server: apache 2.4
  • Database version: Mariadb 10.5.8
  • PHP version: PHP 8.0.2
  • phpMyAdmin version: 5.1.0

Client configuration

  • Browser: Chrome 88
  • Operating system: Windows 10 20H2

Additional context

No problem with PHP 7.4

@neoteknic neoteknic changed the title PHP 8.0 bug quick edit [BUG][PHP8.0] error 500 in quick edit Mar 3, 2021
@williamdes
Copy link
Member

Merci @neoteknic !

@williamdes williamdes self-assigned this Mar 4, 2021
@williamdes williamdes added the Bug A problem or regression with an existing feature label Mar 4, 2021
@williamdes williamdes added this to the 5.1.1 milestone Mar 4, 2021
@williamdes williamdes added this to Needs triage in issues via automation Mar 4, 2021
@williamdes williamdes moved this from Needs triage to High priority in issues Mar 4, 2021
@shucon
Copy link
Contributor

shucon commented Mar 4, 2021

I'm unable to reproduce the issue.

@williamdes
Copy link
Member

Reproduced with substring transformations setup

@williamdes williamdes added the has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete label Mar 6, 2021
@williamdes
Copy link
Member

This is an option that should send an array of where clauses but the code seems to send an array in all cases for this feature

$cfg['SaveCellsAtOnce'] = true;

williamdes added a commit to williamdes/phpmyadmintest that referenced this issue Mar 6, 2021
Signed-off-by: William Desportes <williamdes@wdes.fr>
williamdes added a commit that referenced this issue Mar 6, 2021
Signed-off-by: William Desportes <williamdes@wdes.fr>
issues automation moved this from High priority to Closed Mar 6, 2021
williamdes added a commit that referenced this issue Mar 12, 2021
Signed-off-by: William Desportes <williamdes@wdes.fr>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug A problem or regression with an existing feature has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete
Projects
issues
  
Closed
Development

No branches or pull requests

3 participants