Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Index rename button disapears when dropping a column #16716

Closed
linaspasv opened this issue Mar 5, 2021 · 2 comments · Fixed by #16731
Closed

Index rename button disapears when dropping a column #16716

linaspasv opened this issue Mar 5, 2021 · 2 comments · Fixed by #16731
Assignees
@williamdes
Labels
Bug A problem or regression with an existing feature help wanted ui Issues relating to the user interface
Projects
issues
Milestone
5.1.1

Comments

@linaspasv
Copy link

The bug occures on phpMyAdmin 5.1.0

Before dropping a column:
image

After dropping a column (rename button is gone):
image

Rename button comes back after a page refresh.
@linaspasv
Copy link
Author

#14953 might be partially related to my very old request. Probably a template that's being loaded via ajax when column is dropped should be updated.

@williamdes
Copy link
Member

Thank you @linaspasv for reporting this bug and for the screenshots

@williamdes williamdes added this to Needs triage in issues via automation Mar 5, 2021
@williamdes williamdes added Bug A problem or regression with an existing feature help wanted ui Issues relating to the user interface labels Mar 5, 2021
@williamdes williamdes moved this from Needs triage to n/a priority in issues Mar 5, 2021
@williamdes williamdes added this to the 5.1.1 milestone Mar 5, 2021
@shucon shucon mentioned this issue Mar 12, 2021
Merged
6 tasks
@williamdes williamdes self-assigned this Mar 14, 2021
williamdes added a commit that referenced this issue Mar 14, 2021
@williamdes
Merge #16731 - Fix #16716 - Rename disappears after column drop
337df3a 
Pull-request: #16731
Fixes: #16716

Signed-off-by: William Desportes <williamdes@wdes.fr>
williamdes added a commit that referenced this issue Mar 14, 2021
@williamdes
Add a ChangeLog entry for #16716
34ad4a2 
Signed-off-by: William Desportes <williamdes@wdes.fr>
issues automation moved this from n/a priority to Closed Mar 14, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@williamdes williamdes

Labels
Bug A problem or regression with an existing feature help wanted ui Issues relating to the user interface
Projects
issues
  
Closed
Milestone
5.1.1
Development

Successfully merging a pull request may close this issue.

Fix #16716 - Rename disappears after column drop shucon/phpmyadmin
2 participants
@linaspasv @williamdes